Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.10 #1032

Closed
wants to merge 1 commit into from
Closed

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Oct 27, 2021

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1006 🦕

@hugovk hugovk requested a review from a team October 27, 2021 08:29
@hugovk hugovk requested a review from a team as a code owner October 27, 2021 08:29
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Oct 27, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 27, 2021
@plamut
Copy link
Contributor

plamut commented Oct 27, 2021

@hugovk Thank you for the PR, but before we can claim Python 3.10 support, the test infrastructure needs to be set up first to run the CI checks under Python 3.10 (#1006 (comment)).

It is not guaranteed that the library works with Python 3.10 out of the box, because all dependencies need to support it as well, which may take some time.

@plamut plamut added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 27, 2021
@hugovk
Copy link
Contributor Author

hugovk commented Oct 27, 2021

Thanks, I saw that comment but it's a bit light on detail. Is it something you need to deal with internally? Feel free to close this PR if it's premature!

@plamut
Copy link
Contributor

plamut commented Oct 27, 2021

@hugovk Indeed, it's an internal thing to set up the CI checks. If it was just updating the python_requires setting and the classifiers, it would probably have already been done. 🙂

Closing this for now until all prerequisites are in place and all checks pass under Python 3.10.

@plamut plamut closed this Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.10 support
2 participants