Skip to content

Conversation

@chalmerlowe
Copy link
Collaborator

Removes a layer of scope to avoid unnecessary duplication. As described in Issue 1444, one of the scopes present apparently provides the needed authorization as a superset of the scope that we remove.

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1444 🦕

@chalmerlowe chalmerlowe requested a review from a team February 22, 2023 16:06
@chalmerlowe chalmerlowe requested a review from a team as a code owner February 22, 2023 16:06
@chalmerlowe chalmerlowe requested a review from prash-mi February 22, 2023 16:06
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Feb 22, 2023
@nicain nicain merged commit 665d7ba into main Feb 22, 2023
@nicain nicain deleted the remove-scope branch February 22, 2023 16:55
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
* Fix: removes scope to avoid unnecessary duplication

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"https://www.googleapis.com/auth/bigquery" scope is unecessary

2 participants