Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update opentel to track bytes billed and processed for job queries #1624

Closed
wants to merge 10 commits into from

Conversation

MrwanBaghdad
Copy link

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Update opentel tracing tracking bytes billed and processed for job queries
Link to feature request

@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Jul 24, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Jul 24, 2023
@MrwanBaghdad MrwanBaghdad marked this pull request as ready for review July 24, 2023 16:28
@MrwanBaghdad MrwanBaghdad requested review from a team as code owners July 24, 2023 16:28
@MrwanBaghdad MrwanBaghdad requested a review from prash-mi July 24, 2023 16:28
@MrwanBaghdad MrwanBaghdad changed the title Update opentel tracing tracking bytes billed and processed for job qu… feat: Update opentel to track bytes billed and processed for job queries Jul 25, 2023
@meredithslota meredithslota requested review from shollyman and removed request for prash-mi July 31, 2023 23:28
@kiraksi kiraksi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 18, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 18, 2024
@chalmerlowe
Copy link
Collaborator

@tswast

In looking at this, as best I can tell, this looks like it relies upon AsyncJob, which we define elsewhere but when we define it, we don't initialize the attributes listed in this PR: namely total_bytes_billed and total_bytes_processed.

I am considering going in an seeing about adding those attributes to AsyncJob, so that we can access them here.

Am I missing something?
Is there a better approach?

Copy link
Contributor

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need some unit test coverage before merging this, too.

@tswast
Copy link
Contributor

tswast commented Mar 29, 2024

I am considering going in an seeing about adding those attributes to AsyncJob, so that we can access them here.

I left some suggestions. I don't want to mislead folks by having these properties available on LoadJob for example, which is free and doesn't have such properties.

@chalmerlowe
Copy link
Collaborator

We'll need some unit test coverage before merging this, too.

Agreed.

chalmerlowe and others added 3 commits April 1, 2024 08:38
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
@chalmerlowe
Copy link
Collaborator

@MrwanBaghdad

Couple of things:

  • Are you interested in adding tests to this PR (I can provide some recommendations)?
  • IF not, can you add me as a collaborator to your fork?
    I would like to ensure that we get several tests into the system before approving this PR. The way github.com works, I can't suggest mods to your branch without collab permissions.

See here for details on how to add a collaborator:
https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-access-to-your-personal-repositories/inviting-collaborators-to-a-personal-repository

@chalmerlowe chalmerlowe added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 1, 2024
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 1, 2024
@chalmerlowe
Copy link
Collaborator

This has been migrated to a new PR.
Closing.

@chalmerlowe chalmerlowe closed this Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants