-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update opentel to track bytes billed and processed for job queries #1624
Conversation
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
In looking at this, as best I can tell, this looks like it relies upon AsyncJob, which we define elsewhere but when we define it, we don't initialize the attributes listed in this PR: namely I am considering going in an seeing about adding those attributes to AsyncJob, so that we can access them here. Am I missing something? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need some unit test coverage before merging this, too.
I left some suggestions. I don't want to mislead folks by having these properties available on LoadJob for example, which is free and doesn't have such properties. |
Agreed. |
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
Co-authored-by: Tim Sweña (Swast) <swast@google.com>
Couple of things:
See here for details on how to add a collaborator: |
This has been migrated to a new PR. |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Update opentel tracing tracking bytes billed and processed for job queries
Link to feature request