Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: standardize samples directory #1727

Merged
merged 4 commits into from
Nov 17, 2023
Merged

chore: standardize samples directory #1727

merged 4 commits into from
Nov 17, 2023

Conversation

kiraksi
Copy link
Contributor

@kiraksi kiraksi commented Nov 16, 2023

This PR:

  • Copies samples that require extra dependencies other than google-cloud-bigquery to their own samples folder
  • There will be a following PR to delete the samples from the snippets folder after updating documentation

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #790 🦕

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery API. samples Issues that are directly related to samples. labels Nov 16, 2023
@kiraksi kiraksi changed the title Standardize samples directory chore: standardize samples directory Nov 16, 2023
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Nov 16, 2023
@kiraksi kiraksi requested a review from tswast November 16, 2023 23:06
@kiraksi kiraksi marked this pull request as ready for review November 16, 2023 23:10
@kiraksi kiraksi requested review from a team as code owners November 16, 2023 23:10
@kiraksi kiraksi requested a review from loferris November 16, 2023 23:10
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Nov 16, 2023 •
edited
Loading

Here is the summary of changes.

You are about to add 12 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@kiraksi kiraksi merged commit f804d63 into googleapis:main Nov 17, 2023
4 checks passed
@kiraksi kiraksi deleted the standardize-samples-directory branch November 17, 2023 00:16
@kiraksi kiraksi mentioned this pull request Nov 17, 2023
Merged
4 tasks
kiraksi added a commit to kiraksi/python-bigquery that referenced this pull request Nov 20, 2023
@kiraksi
chore: standardize samples directory (googleapis#1727)
705741e 
* Removed all dependencies from samples/snippets thats not google-cloud-bigquery

* chore: standardizing extra-dependency samples

* readded original dependencies to sample/snippets requirements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@loferris loferris Awaiting requested review from loferris loferris is a code owner automatically assigned from googleapis/python-samples-owners

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. samples Issues that are directly related to samples. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

standardize samples directory layout
2 participants
@kiraksi @tswast