-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: release 1.26.1 #179
Conversation
e88ad79
to
7afa3d7
Compare
CHANGELOG.md
Outdated
|
||
### Bug Fixes | ||
|
||
* address issues with concurrent BigQuery tests [([#3426](https://www.github.com/googleapis/python-bigquery/issues/3426))](https://github.com/GoogleCloudPlatform/python-docs-samples/issues/3426) ([34ad9c6](https://www.github.com/googleapis/python-bigquery/commit/34ad9c619cfc6dcc5356e9375b8c76d41ddc16a1)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably shouldn't be in the changelog or should be reworded? Since the actual change we made was moving the samples to this repo.
BTW, the link #3426 results in 404.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the history merge is causing the issue here, it's actually an older python-docs-samples bug. Will amend the changelog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that we need to reword an item in the history log, otherwise looks good.
e9c4b11
to
b39462c
Compare
pyarrow just went 1.0.0 and appears to have broken this. Started #190 to address the immediate dependency and give us some time to review further arrow changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog is missing an entry for PR #189.
The failing uni tests will be fixed by #192. |
e143228
to
e5fecce
Compare
🤖 I have created a release *beep* *boop*
1.26.1 (2020-07-25)
Bug Fixes
This PR was generated with Release Please.