Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support interval data type (read only) #1832

Closed
wants to merge 3 commits into from
Closed

feat: support interval data type (read only) #1832

wants to merge 3 commits into from

Conversation

kiraksi
Copy link
Contributor

@kiraksi kiraksi commented Feb 26, 2024 •
edited
Loading

This PR:

  • Adds support for interval datatype by converting BQ storage API data to pyarrow.month_day_nano_interval datatype
  • Wraps that pyarrow datatype in a pandas.ArrowDType for library use
  • Adds tests for interval functionality

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #826 (and progress for #836) 🦕

This PR is a work in progress.

@kiraksi kiraksi added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 26, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery API. labels Feb 26, 2024
@kiraksi
Copy link
Contributor Author

kiraksi commented Feb 27, 2024 •
edited
Loading

Closing this WIP PR as the requirements for this feature have changed, please see my comment in the original issue for new plan

@kiraksi kiraksi closed this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support INTERVAL data type
1 participant
@kiraksi