Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cancelling. disregard. #2066

Closed
wants to merge 36 commits into from
Closed

cancelling. disregard. #2066

wants to merge 36 commits into from

Conversation

chalmerlowe
Copy link
Collaborator

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

chalmerlowe and others added 30 commits September 4, 2024 17:12
@chalmerlowe
Adds ExternalCatalogDatasetOptions to Dataset
1b234c8
@chalmerlowe
adds ExternalCatalogTableOptions class and assorted content
8029213
@chalmerlowe
modifies argument names to snake_case
0992bbf
@chalmerlowe
replaces dtype placeholder with parameter names
45ddd89
@chalmerlowe
updates the inclusion of value in properties to use repr version
1411460
@chalmerlowe
updates another inclusion of value in properties to use repr version
20ee950
@chalmerlowe
updates type check via isinstance() or None
bee33ef
@chalmerlowe
Merge branch 'main' into add-pangea-classes
15acfb3
@chalmerlowe
adds tests related to ExternalCatalogDatasetOptions
ee69f24
@chalmerlowe
Merge branch 'main' into add-pangea-classes
aeab931
@chalmerlowe
adds test suite for ExternalCatalogTableOptions and minor tweaks else…
f9d657b 
…where
@chalmerlowe
corrects Error type of failing test
89896a3
@chalmerlowe
forgive me... a wild mess of tests, tweaks, etc
c452459
@chalmerlowe
Updates isinstance_or_raise, refines ExternalCatalogDatasetOptions in…
199e903 
…ternals
@chalmerlowe
Updates ExternalCatalogTableOptions and associated tests
e238ba0
@chalmerlowe
Tweaks several docstrings
5fc89ae
@chalmerlowe
Adds content related to ForeignTypeInfo
68d04f0
@chalmerlowe
add new classes and tests
2a5774e
@chalmerlowe
Merge branch 'main' into add-pangea-classes
cbd08c5
@chalmerlowe
Update tests/unit/test_schema.py
0fcf424
@chalmerlowe @suzmue
Update google/cloud/bigquery/_helpers.py
d7698d2 
Co-authored-by: Suzy Mueller <suzmue@google.com>
@chalmerlowe
updates logic and tests related to _isinstance_or_raise'
43dc45e
@chalmerlowe
updates from_api_repr and a number of tests and cleans up miscellaneo…
4f117a7 
…us cruft'
@chalmerlowe @suzmue
Update google/cloud/bigquery/_helpers.py
defa38c 
Co-authored-by: Suzy Mueller <suzmue@google.com>
@chalmerlowe
Most recent round of tweaks and experiments
14d1bd8
@chalmerlowe
Updates from futures import annotation.
1b7ba09
@chalmerlowe
Updates from_api_repr() and external_config tests
79bbeb2
@chalmerlowe
Updates external_catalog_dataset functions in dataset.py and tests.
d71d904
@chalmerlowe
Adds fixtures, tests, corrections to classes and tests
b0a7fb1
@chalmerlowe
Updates comments and addes a to_api_repr test
d0d96fa
@chalmerlowe chalmerlowe requested review from a team as code owners November 15, 2024 19:42
@chalmerlowe chalmerlowe requested a review from suzmue November 15, 2024 19:42
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: bigquery Issues related to the googleapis/python-bigquery API. labels Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suzmue suzmue Awaiting requested review from suzmue suzmue is a code owner automatically assigned from googleapis/api-bigquery

Assignees

@suzmue suzmue

Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: xl Pull request size is extra large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chalmerlowe @suzmue