Skip to content

Conversation

@walid83-0
Copy link
Contributor

Hi, I updated pyproject.toml following PEP 639.
Please review and merge if everything is fine.

@walid83-0 walid83-0 requested review from a team as code owners September 24, 2025 21:35
@walid83-0 walid83-0 requested a review from logachev September 24, 2025 21:35
@google-cla
Copy link

google-cla bot commented Sep 24, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Sep 24, 2025
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Sep 24, 2025
@chalmerlowe
Copy link
Collaborator

@walid83-0 Thanks for this suggestion. I am considering it.

Please take a look above. In order for me to be able to accept this PR, Google requires that all contributors sign the Google Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

@chalmerlowe
Copy link
Collaborator

@walid83-0

I am curious about the decision to provide a minimum version number for setuptools. What is the rationale for this decision? And why such a recent version of setuptools (i.e. "77.0.3"), which, if memory serves, came out in the past six months.

As a general rule, Google tends to avoid putting too many limits on dependency versions as our library users are a global audience with many different environments. We want to be able to enable customers to use this library with as little friction as possible.

For projects in the Googleapis organization that have pyproject.toml files, I can only find three that include a version number with setuptools and those versions are pretty old {"42", "61.0"}

ACTION: unless we have a really good reason, I request that the version bump be stripped out entirely.

@walid83-0
Copy link
Contributor Author

Thanks for pointing this out. I mistakenly pinned setuptools to 77.0.3 simply because it was the most recent release. I understand now that this creates unnecessary friction for users. Since we don’t depend on any features from that specific version, I’ll update the requirement to be more flexible (>=61) or remove it entirely.
I’m still learning and just wanted to contribute, so thanks for the guidance.

@chalmerlowe
Copy link
Collaborator

Let's just remove the version number completely, please. Thanks!

Thanks for the feedback,
I've removed the version number completely as requested.
@walid83-0
Copy link
Contributor Author

Thanks for the feedback!
I've removed the version number completely as requested.
Please let me know if anything else needs adjustment.

@chalmerlowe chalmerlowe changed the title update pyproject.toml to follow PEP 639 build: update pyproject.toml to follow PEP 639 Oct 13, 2025
@chalmerlowe chalmerlowe added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 13, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 13, 2025
@chalmerlowe chalmerlowe merged commit 4251fee into googleapis:main Oct 13, 2025
29 of 33 checks passed
@chalmerlowe
Copy link
Collaborator

@walid83-0

Thanks for this contribution. Is there something else you might want to work on? I would be happy to chat about some tasks that might be reasonsable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants