Skip to content

Commit

Permalink
add skips into github actions file
Browse files Browse the repository at this point in the history
  • Loading branch information
daniel-sanche committed Sep 27, 2024
1 parent 601edf7 commit 86651db
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 15 deletions.
9 changes: 9 additions & 0 deletions .github/workflows/conformance.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,13 @@ jobs:
test-version: [ "v0.0.2" ]
py-version: [ 3.8 ]
client-type: [ "async", "sync", "legacy" ]
include:
- client-type: "sync"
# sync and legacy client do not support concurrent streams
test_args: "-skip _Generic_MultiStream"
- client-type: "legacy"
# legacy client does not expose mutate_row. Disable those tests
test_argss: "-skip _Generic_MultiStream -skip TestMutateRow_"
fail-fast: false
name: "${{ matrix.client-type }} client / python ${{ matrix.py-version }} / test tag ${{ matrix.test-version }}"
steps:
Expand All @@ -53,4 +60,6 @@ jobs:
env:
CLIENT_TYPE: ${{ matrix.client-type }}
PYTHONUNBUFFERED: 1
TEST_ARGS: ${{ matrix.test_args }}
PROXY_PORT: 9999

16 changes: 1 addition & 15 deletions .kokoro/conformance.sh
Original file line number Diff line number Diff line change
Expand Up @@ -19,22 +19,7 @@ set -eo pipefail
## cd to the parent directory, i.e. the root of the git repo
cd $(dirname $0)/..

PROXY_ARGS=""
TEST_ARGS=""
if [[ $CLIENT_TYPE == "legacy" ]]; then
echo "Using legacy client"
# legacy client does not expose mutate_row. Disable those tests
TEST_ARGS="-skip TestMutateRow_"
fi

if [[ $CLIENT_TYPE != "async" ]]; then
echo "Using legacy client"
# sync and legacy client do not support concurrent streams
TEST_ARGS="$TEST_ARGS -skip _Generic_MultiStream "
fi

# Build and start the proxy in a separate process
PROXY_PORT=9999
pushd test_proxy
nohup python test_proxy.py --port $PROXY_PORT --client_type=$CLIENT_TYPE &
proxyPID=$!
Expand All @@ -48,6 +33,7 @@ function cleanup() {
trap cleanup EXIT

# Run the conformance test
echo "running tests with args: $TEST_ARGS"
pushd cloud-bigtable-clients-test/tests
eval "go test -v -proxy_addr=:$PROXY_PORT $TEST_ARGS"
RETURN_CODE=$?
Expand Down

0 comments on commit 86651db

Please sign in to comment.