chore: add cross_sync annotations #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-sanche
changed the title
mutianf
reviewed
Nov 14, 2024
| ), | ||
| "RAISE_NO_LOOP": ( | ||
| "RuntimeError: if called outside of an async context (no running event loop)", | ||
| "", |
There was a problem hiding this comment.
Ok, let's change this to None to be consistent with other methods?
| if CrossSync.is_async: | ||
| from google.cloud.bigtable.data._async.client import TableAsync as TableType | ||
| else: | ||
| from google.cloud.bigtable.data._sync_autogen.client import Table as TableType # type: ignore |
There was a problem hiding this comment.
dumb question.. isn't _sync_autogen.client also generated from cross sync? how can we import a not yet generated class?
There was a problem hiding this comment.
Yeah, good point, this should really just be in the next PR, since the file doesn't exist yet
For the "how" part: this import statement isn't actually executed, since it's behind an if False branch. This import is just for the generated file
google/cloud/bigtable/data/execute_query/_async/execute_query_iterator.py
Outdated
Show resolved
Hide resolved
Yes, but that's in the next PR, since we don't have the generated files here yet |
mutianf
approved these changes
Nov 19, 2024
daniel-sanche
added
the
cla: yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 2/x for adding the sync surface for the new data client
This PR restructures the existing async library to better support the sync side. Specifically:
Currently, we need to run the conversion process manually (using
python .cross_sync/generate.py, and the sync files are not included in the codebase. The next PR will add the sync artifacts, and add the generation pipeline into the CI system