Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): use read_rows_stream in filter samples #1020

Closed
wants to merge 1 commit into from

Conversation

daniel-sanche
Copy link
Contributor

replace read_rows with read_rows_stream, as it is more efficient

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

replace read_rows with read_rows_stream, as it is more efficient
@daniel-sanche daniel-sanche requested review from a team as code owners September 4, 2024 23:09
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/python-bigtable API. samples Issues that are directly related to samples. labels Sep 4, 2024
@steveniemitz steveniemitz removed their assignment Sep 5, 2024
@igorbernstein2
Copy link
Contributor

what makes this more efficient?

@daniel-sanche
Copy link
Contributor Author

what makes this more efficient?

context: b/347322404

read_rows buffers the entire output before returning the resulting list, read_rows_stream streams gives a generator for acting on the results as they arrive

@daniel-sanche
Copy link
Contributor Author

After discussing this offline, I think we will leave as-is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/python-bigtable API. samples Issues that are directly related to samples. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants