Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding feature flags for routing cookie and retry info #905

Merged
merged 4 commits into from
Jan 11, 2024
Merged

feat: Adding feature flags for routing cookie and retry info #905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c48b68d
feat: Modify ModifyColumnFamiliesRequest proto to expose ignore_warni…
gcf-owl-bot[bot] Dec 14, 2023
5142ede
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Dec 14, 2023
963c57a
feat: Adding feature flags for routing cookie and retry info
gcf-owl-bot[bot] Dec 18, 2023
61a6be7
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions google/cloud/bigtable_admin_v2/types/bigtable_table_admin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,6 +597,9 @@ class ModifyColumnFamiliesRequest(proto.Message):
earlier modifications can be masked by later
ones (in the case of repeated updates to the
same family, for example).
ignore_warnings (bool):
Optional. If true, ignore safety checks when
modifying the column families.
"""

class Modification(proto.Message):
Expand Down Expand Up @@ -662,6 +665,10 @@ class Modification(proto.Message):
number=2,
message=Modification,
)
ignore_warnings: bool = proto.Field(
proto.BOOL,
number=3,
)


class GenerateConsistencyTokenRequest(proto.Message):
Expand Down
16 changes: 16 additions & 0 deletions google/cloud/bigtable_v2/types/feature_flags.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,14 @@ class FeatureFlags(proto.Message):
Notify the server that the client supports the
last_scanned_row field in ReadRowsResponse for long-running
scans.
routing_cookie (bool):
Notify the server that the client supports
using encoded routing cookie strings to retry
requests with.
retry_info (bool):
Notify the server that the client supports
using retry info back off durations to retry
requests with.
"""

reverse_scans: bool = proto.Field(
Expand All @@ -77,6 +85,14 @@ class FeatureFlags(proto.Message):
proto.BOOL,
number=4,
)
routing_cookie: bool = proto.Field(
proto.BOOL,
number=6,
)
retry_info: bool = proto.Field(
proto.BOOL,
number=7,
)


__all__ = tuple(sorted(__protobuf__.manifest))
2 changes: 1 addition & 1 deletion scripts/fixup_bigtable_admin_v2_keywords.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ class bigtable_adminCallTransformer(cst.CSTTransformer):
'list_instances': ('parent', 'page_token', ),
'list_snapshots': ('parent', 'page_size', 'page_token', ),
'list_tables': ('parent', 'view', 'page_size', 'page_token', ),
'modify_column_families': ('name', 'modifications', ),
'modify_column_families': ('name', 'modifications', 'ignore_warnings', ),
'partial_update_cluster': ('cluster', 'update_mask', ),
'partial_update_instance': ('instance', 'update_mask', ),
'restore_table': ('parent', 'table_id', 'backup', ),
Expand Down
Loading