Skip to content

tests.unit.test_date: test_date_parsing_errors[2262-04-12-Out of bounds] failed #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
flaky-bot bot opened this issue Dec 1, 2022 · 2 comments · Fixed by #166
Closed

tests.unit.test_date: test_date_parsing_errors[2262-04-12-Out of bounds] failed #160

flaky-bot bot opened this issue Dec 1, 2022 · 2 comments · Fixed by #166
Labels
api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Dec 1, 2022

This test failed!

To configure my behavior, see the Flaky Bot documentation.

If I'm commenting on this issue too often, add the flakybot: quiet label and
I will stop commenting.


commit: af67adc
buildURL: Build Status, Sponge
status: failed

Test output
value = '2262-04-12', error = 'Out of bounds'
@pytest.mark.parametrize(
    "value, error",
    [
        ("thursday", "Bad date string: 'thursday'"),
        ("1-2-thursday", "Bad date string: '1-2-thursday'"),
        ("1-2-3-4", "Bad date string: '1-2-3-4'"),
        ("1-2-3.f", "Bad date string: '1-2-3.f'"),
        ("1-d-3", "Bad date string: '1-d-3'"),
        ("1-3", "Bad date string: '1-3'"),
        ("1", "Bad date string: '1'"),
        ("", "Bad date string: ''"),
        ("2021-2-99", "day is out of range for month"),
        ("2021-99-1", "month must be in 1[.][.]12"),
        ("10000-1-1", "year 10000 is out of range"),
        # Outside of min/max values pandas.Timestamp.
        ("0001-01-01", "Out of bounds"),
        ("9999-12-31", "Out of bounds"),
        ("1677-09-21", "Out of bounds"),
        ("2262-04-12", "Out of bounds"),
    ],
)
def test_date_parsing_errors(value, error):
  with pytest.raises(ValueError, match=error):

E Failed: DID NOT RAISE <class 'ValueError'>

tests/unit/test_date.py:154: Failed

@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. labels Dec 1, 2022
@flaky-bot
Copy link
Author

flaky-bot bot commented Dec 1, 2022

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.


When run at the same commit (af67adc), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge).

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. label Dec 1, 2022
@tswast
Copy link
Collaborator

tswast commented Dec 20, 2022

Pandas now supports microsecond-precision pandas-dev/pandas#49034

We'll need to add our own validation for nanosecond-precision supported dates as a stop-gap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-db-dtypes-pandas API. flakybot: flaky Tells the Flaky Bot not to close or comment on this issue. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
1 participant