-
Notifications
You must be signed in to change notification settings - Fork 6
Closed
Labels
api: bigqueryIssues related to the googleapis/python-db-dtypes-pandas API.Issues related to the googleapis/python-db-dtypes-pandas API.priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.Important issue which blocks shipping the next release. Will be fixed prior to next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Description
It is claimed that the na_value
is NaT
python-db-dtypes-pandas/db_dtypes/core.py
Line 30 in e9d41d1
na_value = NaT |
But in reality, both dbtime and dbdate return None
when a missing value is present in the array.
python-db-dtypes-pandas/db_dtypes/__init__.py
Line 149 in e9d41d1
return None |
python-db-dtypes-pandas/db_dtypes/__init__.py
Line 254 in e9d41d1
return None |
This inconsistency is causing a few problems, such as broken __contains__
for missing values, discovered while adding compliance tests in #64
Metadata
Metadata
Assignees
Labels
api: bigqueryIssues related to the googleapis/python-db-dtypes-pandas API.Issues related to the googleapis/python-db-dtypes-pandas API.priority: p1Important issue which blocks shipping the next release. Will be fixed prior to next release.Important issue which blocks shipping the next release. Will be fixed prior to next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.