Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: Update Firestore to use Microgeneration #63

Closed
wants to merge 68 commits into from
Closed

feat!: Update Firestore to use Microgeneration #63

wants to merge 68 commits into from

Conversation

crwilcox
Copy link
Contributor

/wip

@crwilcox crwilcox added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 23, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 23, 2020
@busunkim96
Copy link
Contributor

@crwilcox What is the role of test_pb2.py? I don't see a proto file in https://github.com/googleapis/googleapis/tree/master/google/firestore/v1beta1

@crwilcox
Copy link
Contributor Author

@busunkim96 These are used for cross_language test harnesses

@crwilcox crwilcox added release-please:force-run To run release-please and removed release-please:force-run To run release-please labels Jul 6, 2020
@crwilcox
Copy link
Contributor Author

Closing this PR, continued in #91

@crwilcox crwilcox closed this Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crwilcox @busunkim96 @googlebot