feat: Sum/Avg aggregation queries #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the ability to perform sum/avg aggregation query through: - query.sum(), - query.avg(), - async_query.sum(), - async_query.avg()
product-auto-label
bot
added
size: l
daniel-sanche
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
4 tasks
product-auto-label
bot
added
size: xl
daniel-sanche
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
daniel-sanche
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
kolea2
suggested changes
Aug 29, 2023
tests/system/test_system.py
Outdated
| for aggregation_result in result: | ||
| assert aggregation_result.alias in ["total", "all"] | ||
|
|
||
|
|
||
| @firestore.transactional |
There was a problem hiding this comment.
can we add some additional tests for transactions using sum/avg?
There was a problem hiding this comment.
I added a couple, let me know what you think
kolea2
reviewed
Oct 4, 2023
| @@ -507,6 +507,30 @@ def count(self, alias=None): | |||
| """ | |||
| return self._aggregation_query().count(alias=alias) | |||
|
|
|||
| def sum(self, field_ref: str, alias=None): | |||
There was a problem hiding this comment.
does FieldPath need to be appended here as well?
There was a problem hiding this comment.
good catch! Fixed
(The type checking system should have caught this, but it looks like it's not running properly. I'll have to fix that in a separate PR)
There was a problem hiding this comment.
sgtm, please file an issue for tracking!
There was a problem hiding this comment.
I have a bug for it here: #773
daniel-sanche
added
the
kokoro:run
yoshi-kokoro
removed
the
kokoro:run
daniel-sanche
added
the
kokoro:run
yoshi-kokoro
removed
the
kokoro:run
daniel-sanche
added
the
kokoro:run
yoshi-kokoro
removed
the
kokoro:run
|
Note: the new EDIT: we are going to release with tests skipped, and re-enable them when the backend fix is ready |
kolea2
approved these changes
Oct 18, 2023
daniel-sanche
added
the
kokoro:run
yoshi-kokoro
removed
the
kokoro:run
daniel-sanche
added
the
kokoro:run
yoshi-kokoro
removed
the
kokoro:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to perform sum/avg aggregation query through:
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕