Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: populate transaction attributes after commit #977

Merged
merged 4 commits into from
Oct 25, 2024
Merged

fix: populate transaction attributes after commit #977

merged 4 commits into from
Oct 25, 2024

Conversation

daniel-sanche
Copy link
Contributor

Transaction and AsyncTransaction inherit from Batch, which includes fields to store write_results and commit_time after commit is complete, but they are currently not populated for Transaction types. This PR addresses this by populating the fields with the commit response

Fixes #927

@daniel-sanche daniel-sanche requested review from a team as code owners October 22, 2024 22:43
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Oct 22, 2024
@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Oct 22, 2024
@kevkim-codes kevkim-codes merged commit aa3c0a3 into main Oct 25, 2024
22 checks passed
@kevkim-codes kevkim-codes deleted the transaction_commit_time branch October 25, 2024 15:08
@release-please release-please bot mentioned this pull request Oct 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevkim-codes kevkim-codes kevkim-codes approved these changes

Assignees

@MarkDuckworth MarkDuckworth

Labels
api: firestore Issues related to the googleapis/python-firestore API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
3 participants
@daniel-sanche @kevkim-codes @MarkDuckworth