docs: add initialization of LogEntry instance in the v2 example #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
ymotongpoo
changed the title
ymotongpoo
commented
Jun 29, 2020
| @@ -84,7 +84,9 @@ Using the API | |||
| from google.cloud import logging_v2 | |||
|
|
|||
| client = logging_v2.LoggingServiceV2Client() | |||
| entries = [] | |||
There was a problem hiding this comment.
Though this PR only changed the issue that the list entries is empty, I think we need to add how to set resources and log_name. What do you think?
There was a problem hiding this comment.
Yes, that would be useful to have too.
There was a problem hiding this comment.
Thanks, I added the note.
simonz130
reviewed
Jun 29, 2020
README.rst
Outdated
| @@ -84,7 +84,9 @@ Using the API | |||
| from google.cloud import logging_v2 | |||
|
|
|||
| client = logging_v2.LoggingServiceV2Client() | |||
| entries = [] | |||
| e = logging_v2.types.LogEntry( | |||
| text_payload="text") | |||
There was a problem hiding this comment.
please update "Text" to something more meaningful, like "this is a log statement"
There was a problem hiding this comment.
I used the exact phrase :)
|
@simonz130 Thank you Simon for the check. I updated the pull request. |
simonz130
approved these changes
Jul 1, 2020
simonz130
added
api: logging
yoshi-kokoro
removed
the
kokoro:run
simonz130
added
the
kokoro:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #44