docs: add samples from logging/cloud-client #67

busunkim96 · 2020-10-12T16:06:11Z

Samples from https://github.com/GoogleCloudPlatform/python-docs-samples/tree/master/logging/cloud-client

google-cla · 2020-10-12T16:06:38Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2020-10-12T16:17:59Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

daniel-sanche

LGTM. I fixed the failing unit/system tests here: #70. Still working on the last docs check that's failing, then hopefully we can merge these together

What's the long term plan for samples? Will we remove them out of python-docs-samples after this is merged? Do we need to update all the docs to point to the new samples home too?

busunkim96 · 2020-10-14T22:21:39Z

Thanks @daniel-sanche!

What's the long term plan for samples? Will we remove them out of python-docs-samples after this is merged? Do we need to update all the docs to point to the new samples home too?

Yes and yes. Once this is merged I'll (1) create a CL to point the docs here and (2) remove the samples from python-docs-samples.

You can ignore docs-presubmit if that's the only thing that's failing. It is for the cloud docs folks but is not a required check quite yet.

daniel-sanche · 2020-10-15T20:02:03Z

Ok, yeah it looks like it might be a bit of work to get the docs test to pass, so probably better as a separate PR. My test PR should be ready to review now then!

google-cla · 2020-10-19T21:27:49Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2020-10-20T19:18:22Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

simonz130 · 2020-10-21T00:00:46Z

.github/CODEOWNERS

@@ -5,7 +5,7 @@
 # https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners#codeowners-syntax

 # The @googleapis/yoshi-python is the default owner for changes in this repo
-*               @googleapis/yoshi-python
+*               @simonz130 @daniel-sanche @googleapis/yoshi-python


Please change it to @googleapis/api-logging

.github/CODEOWNERS

google-cla · 2020-10-21T00:08:07Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

…es. [(googleapis#435)](GoogleCloudPlatform/python-docs-samples#435)

Change-Id: I67e149dc43ebdb11144ac3839e062aa4668ebb2e

Change-Id: I866edcc956fda2265dd7af7b774336930ec6a151

…on-docs-samples#456)

Change-Id: Ieaf7237fc6f925daec46a07d2e81a452b841198a

Change-Id: I02e7767d13ba267ee9fc72c5b68a57013bb8b8d3

…udPlatform/python-docs-samples#1464)

…mples#1634)

…ples#1801) logging.warn -> logging.warning to fix "DeprecationWarning: The 'warn' function is deprecated, use 'warning' instead"

…amples#1846) ACK, merging.

…amples#1980) * Auto-update dependencies. * Update requirements.txt * Update requirements.txt

…latform/python-docs-samples#2438)

…amples#2005) * Auto-update dependencies. * Revert update of appengine/flexible/datastore. * revert update of appengine/flexible/scipy * revert update of bigquery/bqml * revert update of bigquery/cloud-client * revert update of bigquery/datalab-migration * revert update of bigtable/quickstart * revert update of compute/api * revert update of container_registry/container_analysis * revert update of dataflow/run_template * revert update of datastore/cloud-ndb * revert update of dialogflow/cloud-client * revert update of dlp * revert update of functions/imagemagick * revert update of functions/ocr/app * revert update of healthcare/api-client/fhir * revert update of iam/api-client * revert update of iot/api-client/gcs_file_to_device * revert update of iot/api-client/mqtt_example * revert update of language/automl * revert update of run/image-processing * revert update of vision/automl * revert update testing/requirements.txt * revert update of vision/cloud-client/detect * revert update of vision/cloud-client/product_search * revert update of jobs/v2/api_client * revert update of jobs/v3/api_client * revert update of opencensus * revert update of translate/cloud-client * revert update to speech/cloud-client Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com> Co-authored-by: Doug Mahugh <dmahugh@gmail.com>

…1)](GoogleCloudPlatform/python-docs-samples#3161) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [google-cloud-logging](https://togithub.com/googleapis/python-logging) | minor | `==1.14.0` -> `==1.15.0` | --- ### Release Notes <details> <summary>googleapis/python-logging</summary> ### [`v1.15.0`](https://togithub.com/googleapis/python-logging/blob/master/CHANGELOG.md#1150httpswwwgithubcomgoogleapispython-loggingcomparev1140v1150-2020-02-26) [Compare Source](https://togithub.com/googleapis/python-logging/compare/v1.14.0...v1.15.0) ##### Features - add support for cmek settings; undeprecate resource name helper methods; bump copyright year to 2020 ([#22](https://www.github.com/googleapis/python-logging/issues/22)) ([1c687c1](https://www.github.com/googleapis/python-logging/commit/1c687c168cdc1f5ebc74d2380ad87335a42209a2)) ##### Bug Fixes - **logging:** deprecate resource name helper methods (via synth) ([#9837](https://www.github.com/googleapis/python-logging/issues/9837)) ([335af9e](https://www.github.com/googleapis/python-logging/commit/335af9e909eb7fb4696ba906a82176611653531d)) - **logging:** update test assertion and core version pins ([#10087](https://www.github.com/googleapis/python-logging/issues/10087)) ([4aedea8](https://www.github.com/googleapis/python-logging/commit/4aedea80e2bccb5ba3c41fae7a0ee46cc07eefa9)) - replace unsafe six.PY3 with PY2 for better future compatibility with Python 4 ([#10081](https://www.github.com/googleapis/python-logging/issues/10081)) ([c6eb601](https://www.github.com/googleapis/python-logging/commit/c6eb60179d674dfd5137d90d209094c9369b3581)) </details> --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Never, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#GoogleCloudPlatform/python-docs-samples).

…ples#2806) * chore(deps): update dependency requests to v2.23.0 * Simplify noxfile and add version control. * Configure appengine/standard to only test Python 2.7. * Update Kokokro configs to match noxfile. * Add requirements-test to each folder. * Remove Py2 versions from everything execept appengine/standard. * Remove conftest.py. * Remove appengine/standard/conftest.py * Remove 'no-sucess-flaky-report' from pytest.ini. * Add GAE SDK back to appengine/standard tests. * Fix typo. * Roll pytest to python 2 version. * Add a bunch of testing requirements. * Remove typo. * Add appengine lib directory back in. * Add some additional requirements. * Fix issue with flake8 args. * Even more requirements. * Readd appengine conftest.py. * Add a few more requirements. * Even more Appengine requirements. * Add webtest for appengine/standard/mailgun. * Add some additional requirements. * Add workaround for issue with mailjet-rest. * Add responses for appengine/standard/mailjet. Co-authored-by: Renovate Bot <bot@renovateapp.com>

…form/python-docs-samples#3477)

…leCloudPlatform/python-docs-samples#3691) * Update handler.py * Update README.rst * Update handler.py Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>

…amples#3877) * testing: various cleanups * [iap]: only run iap tests on Kokoro * [vision/automl]: use temporary directory for temporary files * [appengine/flexible/scipy]: use temporary directory * [bigtable/snippets/reads]: update pytest snapshot * [texttospeech/cloud-client]: added output.mp3 to .gitignore * [iot/api-client/gcs_file_to_device]: use temporary directory * [iot/api-client/mqtt_example]: use temporary directory * [logging/cloud-client]: use uuid and add backoff * use project directory with Trampoline V1

…Platform/python-docs-samples#4279) * chore(deps): update dependency pytest to v5.4.3 * specify pytest for python 2 in appengine Co-authored-by: Leah Cole <coleleah@google.com>

…ocs-samples#4390)

…8)](GoogleCloudPlatform/python-docs-samples#4458)

google-cla · 2020-10-30T22:35:08Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2020-10-30T23:05:46Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

busunkim96 requested a review from a team as a code owner October 12, 2020 16:06

busunkim96 requested a review from tmatsuo October 12, 2020 16:06

google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Oct 12, 2020

busunkim96 requested a review from a team as a code owner October 12, 2020 16:17

busunkim96 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 12, 2020

daniel-sanche approved these changes Oct 13, 2020

View reviewed changes

daniel-sanche added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 13, 2020

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 13, 2020

daniel-sanche mentioned this pull request Oct 13, 2020

fix: samples tests should pass if no samples exist googleapis/synthtool#803

Merged

tmatsuo approved these changes Oct 16, 2020

View reviewed changes

daniel-sanche added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Oct 19, 2020

google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Oct 20, 2020

daniel-sanche mentioned this pull request Oct 20, 2020

chore: add logging team to codeowners GoogleCloudPlatform/python-docs-samples#4876

Merged

8 tasks

simonz130 reviewed Oct 21, 2020

View reviewed changes

daniel-sanche mentioned this pull request Oct 26, 2020

logging.cloud-client.snippets_test: test_list failed GoogleCloudPlatform/python-docs-samples#4528

Closed

Jon Wayne Parrott and others added 6 commits October 30, 2020 22:31

Update logging samples to fit new style guide and match Node.js sampl…

afead75

…es. [(googleapis#435)](GoogleCloudPlatform/python-docs-samples#435)

Fix test conflict.

6421e39

Change-Id: I67e149dc43ebdb11144ac3839e062aa4668ebb2e

Fix logging test.

2fda085

Change-Id: I866edcc956fda2265dd7af7b774336930ec6a151

Auto-update dependencies. [(googleapis#456)](GoogleCloudPlatform/pyth…

ba89e94

…on-docs-samples#456)

Fix import order lint errors

6384f59

Change-Id: Ieaf7237fc6f925daec46a07d2e81a452b841198a

bump

a461759

Change-Id: I02e7767d13ba267ee9fc72c5b68a57013bb8b8d3

frankyn and others added 16 commits October 30, 2020 22:31

Update READMEs to fix numbering and add git clone [(#1464)](GoogleClo…

a88dae7

…udPlatform/python-docs-samples#1464)

Update logging doc tags. [(#1634)](GoogleCloudPlatform/python-docs-sa…

2f5a2c4

…mples#1634)

Fix deprecation warning [(#1801)](GoogleCloudPlatform/python-docs-sam…

87be104

…ples#1801) logging.warn -> logging.warning to fix "DeprecationWarning: The 'warn' function is deprecated, use 'warning' instead"

Auto-update dependencies. [(#1846)](GoogleCloudPlatform/python-docs-s…

2d85cca

…amples#1846) ACK, merging.

Auto-update dependencies. [(#1980)](GoogleCloudPlatform/python-docs-s…

62a2697

…amples#1980) * Auto-update dependencies. * Update requirements.txt * Update requirements.txt

Adds split updates for Firebase ... opencensus [(#2438)](GoogleCloudP…

5214909

…latform/python-docs-samples#2438)

[logging] chore: remove gcp-devrel-py-tools [(#3477)](GoogleCloudPlat…

4321a87

…form/python-docs-samples#3477)

Update logging example to retrieve the default handler [(#3691)](Goog…

e026945

…leCloudPlatform/python-docs-samples#3691) * Update handler.py * Update README.rst * Update handler.py Co-authored-by: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>

chore(deps): update dependency pytest to v5.4.3 [(#4279)](GoogleCloud…

e82be62

…Platform/python-docs-samples#4279) * chore(deps): update dependency pytest to v5.4.3 * specify pytest for python 2 in appengine Co-authored-by: Leah Cole <coleleah@google.com>

Update dependency pytest to v6 [(#4390)](GoogleCloudPlatform/python-d…

ef37799

…ocs-samples#4390)

chore(deps): update dependency google-cloud-logging to v1.15.1 [(#445…

60f8cb5

…8)](GoogleCloudPlatform/python-docs-samples#4458)

chore: update templates

26bb29c

busunkim96 force-pushed the add-snippets-samples branch from 56a8f64 to 26bb29c Compare October 30, 2020 22:34

busunkim96 requested a review from a team as a code owner October 30, 2020 22:34

busunkim96 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Oct 30, 2020

chore: remove multiprocessing note

6e07455

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 30, 2020

busunkim96 added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 30, 2020

daniel-sanche added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Oct 30, 2020

busunkim96 merged commit 2b57b0e into googleapis:master Oct 30, 2020

busunkim96 deleted the add-snippets-samples branch October 30, 2020 23:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: add samples from logging/cloud-client #67

docs: add samples from logging/cloud-client #67

busunkim96 commented Oct 12, 2020

google-cla bot commented Oct 12, 2020

google-cla bot commented Oct 12, 2020

daniel-sanche left a comment

busunkim96 commented Oct 14, 2020

daniel-sanche commented Oct 15, 2020

google-cla bot commented Oct 19, 2020

google-cla bot commented Oct 20, 2020

simonz130 Oct 21, 2020

google-cla bot commented Oct 21, 2020

google-cla bot commented Oct 30, 2020

google-cla bot commented Oct 30, 2020

docs: add samples from logging/cloud-client #67

docs: add samples from logging/cloud-client #67

Conversation

busunkim96 commented Oct 12, 2020

google-cla bot commented Oct 12, 2020

google-cla bot commented Oct 12, 2020

daniel-sanche left a comment

Choose a reason for hiding this comment

busunkim96 commented Oct 14, 2020

daniel-sanche commented Oct 15, 2020

google-cla bot commented Oct 19, 2020

google-cla bot commented Oct 20, 2020

simonz130 Oct 21, 2020

Choose a reason for hiding this comment

google-cla bot commented Oct 21, 2020

google-cla bot commented Oct 30, 2020

google-cla bot commented Oct 30, 2020