fix: add default filter settings to list_entries #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
daniel-sanche
added
the
do not merge
busunkim96
approved these changes
Oct 15, 2020
tseaver
reviewed
Oct 21, 2020
| @@ -242,6 +243,7 @@ def list_entries( | |||
| :param filter_: | |||
| a filter expression. See | |||
| https://cloud.google.com/logging/docs/view/advanced_filters | |||
| By default, a 24 hour filter is applied. | |||
There was a problem hiding this comment.
Do we need to flag this as a breaking change?
tseaver
reviewed
Oct 21, 2020
| @@ -97,7 +97,7 @@ def default(session, django_dep=('django',)): | |||
| ) | |||
|
|
|||
|
|
|||
| @nox.session(python=['2.7', '3.5', '3.6', '3.7']) | |||
There was a problem hiding this comment.
Dropping Python 2.7 support is definitely a breaking change.
There was a problem hiding this comment.
Sorry, still getting used to the conventional commit style. Yes, this PR introduces a breaking change (more discussion on the release PR). How do you think we should proceed since it was already merged without the breaking label?
There was a problem hiding this comment.
Given that we haven't removed the Python :: 2 entry from setup.py yet, we can repair the breakage by doing that in another PR.
|
I'm working on handling this in Go lib as well, but realized that checking Very edge case but may lead to an issue report down the line |
|
Hmm good point. I opened #86 to discuss the issue. Thanks! |
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Nov 19, 2020
🤖 I have created a release \*beep\* \*boop\* --- ## [2.0.0](https://www.github.com/googleapis/python-logging/compare/v1.15.1...v2.0.0) (2020-11-19) ### ⚠ BREAKING CHANGES * Use microgenerator for GAPIC layer. See [UPGRADING.md](https://github.com/googleapis/python-logging/blob/master/UPGRADING.md) for details. (#94) * removes support for webapp2 and other Python2 specific code ### Features * pass 'client_options' to super ctor ([#61](https://www.github.com/googleapis/python-logging/issues/61)) ([c4387b3](https://www.github.com/googleapis/python-logging/commit/c4387b307f8f3502fb53ae1f7e1144f6284280a4)), closes [#55](https://www.github.com/googleapis/python-logging/issues/55) * use microgenerator ([#94](https://www.github.com/googleapis/python-logging/issues/94)) ([ff90fd2](https://www.github.com/googleapis/python-logging/commit/ff90fd2fb54c612fe6ab29708a2d5d984f60dea7)) ### Bug Fixes * add default filter settings to list_entries ([#73](https://www.github.com/googleapis/python-logging/issues/73)) ([0a1dd94](https://www.github.com/googleapis/python-logging/commit/0a1dd94811232634fdb849cb2c85bd44e870642f)) * failing CI tests ([#70](https://www.github.com/googleapis/python-logging/issues/70)) ([96adeed](https://www.github.com/googleapis/python-logging/commit/96adeedbda16a5c21651c356261442478aaa867a)) ### Code Refactoring * remove python2 ([#78](https://www.github.com/googleapis/python-logging/issues/78)) ([bf579e4](https://www.github.com/googleapis/python-logging/commit/bf579e4f871c92391a9f6f87eca931744158e31a)) ### Documentation * update docs ([#77](https://www.github.com/googleapis/python-logging/issues/77)) ([bdd9c44](https://www.github.com/googleapis/python-logging/commit/bdd9c440f29d1fcd6fb9545d8465c63efa6c0cea)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71 🦕
The
list_entriesfunctions currently have no filters applied, and the default settings take ~5 minutes for a single query. This PR matches the functionality ofgcloud logging readby adding a default 24 hour filter to the query. If the user provides their own filter statement, the two statements will be appended, unless they explicitly set their own timestamp value