Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add a link to Pub/Sub filtering language public documentation to pubsub.proto #121

Merged
merged 6 commits into from
Jul 6, 2020
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion google/cloud/pubsub_v1/gapic/subscriber_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,8 @@ def create_subscription(

If a dict is provided, it must be of the same form as the protobuf
message :class:`~google.cloud.pubsub_v1.types.ExpirationPolicy`
filter_ (str): An expression written in the Cloud Pub/Sub filter language. If
filter_ (str): An expression written in the Pub/Sub `filter
language <https://cloud.google.com/pubsub/docs/filtering>`__. If
non-empty, then only ``PubsubMessage``\ s whose ``attributes`` field
matches the filter are delivered on this subscription. If empty, then no
messages are filtered out.
Expand Down
28 changes: 26 additions & 2 deletions google/cloud/pubsub_v1/proto/pubsub.proto
Original file line number Diff line number Diff line change
Expand Up @@ -191,7 +191,8 @@ message PubsubMessage {
bytes data = 1;

// Attributes for this message. If this field is empty, the message must
// contain non-empty data.
// contain non-empty data. This can be used to filter messages on the
// subscription.
map<string, string> attributes = 2;

// ID of this message, assigned by the server when the message is published.
Expand Down Expand Up @@ -700,7 +701,8 @@ message Subscription {
// value for `expiration_policy.ttl` is 1 day.
ExpirationPolicy expiration_policy = 11;

// An expression written in the Cloud Pub/Sub filter language. If non-empty,
// An expression written in the Pub/Sub [filter
// language](https://cloud.google.com/pubsub/docs/filtering). If non-empty,
// then only `PubsubMessage`s whose `attributes` field matches the filter are
// delivered on this subscription. If empty, then no messages are filtered
// out.
Expand Down Expand Up @@ -1107,6 +1109,28 @@ message StreamingPullRequest {
// transferred to the new stream. The same client_id should not be used for
// different client instances.
string client_id = 6;

// Flow control settings for the maximum number of outstanding messages. When
// there are `max_outstanding_messages` or more currently sent to the
// streaming pull client that have not yet been acked or nacked, the server
// stops sending more messages. The sending of messages resumes once the
// number of outstanding messages is less than this value. If the value is
// <= 0, there is no limit to the number of outstanding messages. This
// property can only be set on the initial StreamingPullRequest. If it is set
// on a subsequent request, the stream will be aborted with status
// `INVALID_ARGUMENT`.
int64 max_outstanding_messages = 7;

// Flow control settings for the maximum number of outstanding bytes. When
// there are `max_outstanding_bytes` or more worth of messages currently sent
// to the streaming pull client that have not yet been acked or nacked, the
// server will stop sending more messages. The sending of messages resumes
// once the number of outstanding bytes is less than this value. If the value
// is <= 0, there is no limit to the number of outstanding bytes. This
// property can only be set on the initial StreamingPullRequest. If it is set
// on a subsequent request, the stream will be aborted with status
// `INVALID_ARGUMENT`.
int64 max_outstanding_bytes = 8;
}

// Response for the `StreamingPull` method. This response is used to stream
Expand Down
165 changes: 135 additions & 30 deletions google/cloud/pubsub_v1/proto/pubsub_pb2.py

Large diffs are not rendered by default.

Loading