revert: remove graceful streaming pull shutdown #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 00874fe.
product-auto-label
bot
added
the
api: pubsub
google-cla
bot
added
the
cla: yes
anguillanneuf
changed the title
busunkim96
approved these changes
Mar 10, 2021
busunkim96
changed the title
|
@anguillanneuf Sorry to edit the title on you again. I checked the conventional commit spec and it turns out there's a |
This was referenced Mar 10, 2021
plamut
added a commit
that referenced
this pull request
Mar 24, 2021
* Revert "revert: add graceful streaming pull shutdown (#315)" This reverts commit 16bf588. * Move await_msg_callbacks to subscribe() method This is to keep the StreamingPullFuture's surface intact for compatibility with PubSub Lite client. * Make streaming pull close() method non-blocking * Add a blocking streaming pull shutdown sample * Refine docs on awaiting callbacks on shutdown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #292
Release 2.4.0 which contains this feature has been yanked from PyPi: https://pypi.org/project/google-cloud-pubsub/
Graceful streaming pull shutdown introduces an optional wait on callbacks on streaming pull futures. It would otherwise break the streaming pull future returned by the Pub/Sub Lite subscriber client. See googleapis/python-pubsublite#95