Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release 2.4.1 #347

Merged
merged 3 commits into from
Mar 30, 2021
Merged

chore: release 2.4.1 #347

merged 3 commits into from
Mar 30, 2021

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Mar 24, 2021

This is a release PR with polished release notes (supersedes #346).

@plamut plamut requested a review from a team as a code owner March 24, 2021 09:14
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/python-pubsub API. label Mar 24, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 24, 2021
@plamut plamut mentioned this pull request Mar 24, 2021
@anguillanneuf
Copy link
Contributor

I think the release notes in the release bot-proposed PR are editable. In Java at least, the edits in the samples directory are not included in the release notes.

@plamut
Copy link
Contributor Author

plamut commented Mar 29, 2021

@anguillanneuf Are you saying that if one edits the release PR's description, that those changes also get reflected in CHANGELOG.md? That would indeed be quite useful.

@plamut
Copy link
Contributor Author

plamut commented Mar 29, 2021

Since I might be partially offline tomorrow and won't be able to jump in immediately if anything breaks, I would postpone merging this until Tuesday afternoon or Wednesday morning, unless someone has free cycles to be on alert?

cc: @pradn

@anguillanneuf
Copy link
Contributor

@plamut I believe so. I never touched change.md in the Java repos I know and it has been self-updating based on commit messages.

@plamut
Copy link
Contributor Author

plamut commented Mar 29, 2021

@anguillanneuf Ah, what I meant was amending the notes if commit messages themselves are incomplete or contain typos (it happens occasionally). One then needs to update CHANGELOG.md manually, or...?

@anguillanneuf
Copy link
Contributor

anguillanneuf commented Mar 29, 2021

@plamut Updating the PR description should be enough. We can give it a try to see if it indeed does too. Published release notes can be edited as well in the release notes page if something slips through unintended.

CHANGELOG.md Outdated Show resolved Hide resolved
@plamut plamut added the automerge Merge the pull request once unit tests and other checks pass. label Mar 30, 2021
@plamut plamut merged commit b42ac2e into googleapis:master Mar 30, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 30, 2021
@yoshi-automation
Copy link
Contributor

@plamut
Copy link
Contributor Author

plamut commented Mar 30, 2021

@busunkim96 Is the release bot stuck? Shouldn't it publish a release to PyPI in 15 minutes or so after tagging a release? :)

@plamut plamut mentioned this pull request Mar 30, 2021
@plamut plamut deleted the release-2.4.1 branch March 31, 2021 08:42
@release-tool-publish-reporter

The release build has started, the log can be viewed here. 🌻

@release-tool-publish-reporter

🥚 You hatched a release! The release build finished successfully! 💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. autorelease: published cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants