-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: release 2.4.1 #347
chore: release 2.4.1 #347
Conversation
I think the release notes in the release bot-proposed PR are editable. In Java at least, the edits in the samples directory are not included in the release notes. |
@anguillanneuf Are you saying that if one edits the release PR's description, that those changes also get reflected in |
Since I might be partially offline tomorrow and won't be able to jump in immediately if anything breaks, I would postpone merging this until Tuesday afternoon or Wednesday morning, unless someone has free cycles to be on alert? cc: @pradn |
@plamut I believe so. I never touched |
@anguillanneuf Ah, what I meant was amending the notes if commit messages themselves are incomplete or contain typos (it happens occasionally). One then needs to update |
@plamut Updating the PR description should be enough. We can give it a try to see if it indeed does too. Published release notes can be edited as well in the release notes page if something slips through unintended. |
@busunkim96 Is the release bot stuck? Shouldn't it publish a release to PyPI in 15 minutes or so after tagging a release? :) |
The release build has started, the log can be viewed here. 🌻 |
🥚 You hatched a release! The release build finished successfully! 💜 |
This is a release PR with polished release notes (supersedes #346).