Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: fix typo in project_path in upgrade guide #660

Merged
merged 1 commit into from
Apr 18, 2022
Merged

Docs: fix typo in project_path in upgrade guide #660

merged 1 commit into from
Apr 18, 2022

Conversation

acocuzzo
Copy link
Contributor

@acocuzzo acocuzzo commented Apr 18, 2022 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #659 🦕

@acocuzzo acocuzzo requested review from a team as code owners April 18, 2022 18:50
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/python-pubsub API. labels Apr 18, 2022
@acocuzzo acocuzzo merged commit 20d661c into googleapis:main Apr 18, 2022
@release-please release-please bot mentioned this pull request Apr 18, 2022
Merged
@release-please release-please bot mentioned this pull request Aug 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anguillanneuf anguillanneuf anguillanneuf approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo in project string in upgrading guide
2 participants
@acocuzzo @anguillanneuf