Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: import mock via unittest.mock #702

Merged
merged 73 commits into from
Sep 21, 2022
Merged

test: import mock via unittest.mock #702

merged 73 commits into from
Sep 21, 2022

Conversation

major
Copy link
Contributor

@major major commented Jun 1, 2022

The mock module is deprecated and modern versions of Python havd
mock available in the unittest standard library.

Fixes: #701

Signed-off-by: Major Hayden major@mhtx.net

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@major
Import mock via unittest.mock
433aa3e 
The `mock` module is deprecated and modern versions of Python havd
`mock` available in the `unittest` standard library.

Fixes: #701

Signed-off-by: Major Hayden <major@mhtx.net>
@major major requested review from a team as code owners June 1, 2022 21:27
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: pubsub Issues related to the googleapis/python-pubsub API. labels Jun 1, 2022
@parthea parthea self-assigned this Jun 6, 2022
@acocuzzo acocuzzo changed the title Import mock via unittest.mock test: import mock via unittest.mock Jun 9, 2022
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Aug 4, 2022
@acocuzzo acocuzzo added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 8, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 8, 2022
@acocuzzo acocuzzo added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 20, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 20, 2022
@acocuzzo acocuzzo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 21, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 21, 2022
@acocuzzo acocuzzo merged commit f3ebbae into googleapis:main Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acocuzzo acocuzzo acocuzzo left review comments

@samarthsingal samarthsingal samarthsingal approved these changes

Assignees

@parthea parthea

Labels
api: pubsub Issues related to the googleapis/python-pubsub API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use unittest.mock instead of mock
5 participants
@major @samarthsingal @acocuzzo @parthea @yoshi-kokoro