Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move version to gapic_version.py #830

Merged
merged 6 commits into from
Dec 2, 2022

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Dec 2, 2022

fix(deps): require grpcio-status>=1.33.2
fix(deps): require google-api-core[grpc] >= 1.33.2

This PR includes the following changes:

  • Configure release-please to use a manifest file
  • Clean up owlbot.py
  • Clean up setup.py
  • Move the hardcoded version out of setup.py and into gapic_version.py
  • Configure release-please to update the version in gapic_version.py and autogenerated snippets json files.
  • Require grpcio-status >= 1.33.2 to match google-api-core https://github.com/googleapis/python-api-core/blob/main/setup.py#L39
  • Require google-api-core[grpc] >= 1.33.2
partheniou@partheniou-vm-2:~/.repo/python-pubsub$ python3
Python 3.7.13 (default, Nov 10 2022, 15:01:44) 
[GCC 12.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import google.pubsub
>>> import google.pubsub_v1
>>> google.pubsub.__version__
'2.13.11'
>>> google.pubsub_v1.__version__
'2.13.11'

@parthea parthea requested review from a team as code owners December 2, 2022 16:39
@parthea parthea requested a review from atulep December 2, 2022 16:39
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. api: pubsub Issues related to the googleapis/python-pubsub API. labels Dec 2, 2022
Copy link
Contributor

@acocuzzo acocuzzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@acocuzzo acocuzzo merged commit f3bf21d into main Dec 2, 2022
@acocuzzo acocuzzo deleted the move-version-to-gapic-version-py branch December 2, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants