Skip to content

ci: Refactor system tests with transport #870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 17, 2023
Merged

ci: Refactor system tests with transport #870

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f372b62
ci: Refactor system tests
acocuzzo Feb 17, 2023
e0ef4ce
Merge branch 'main' into refactor-sys-tests
acocuzzo Feb 17, 2023
4e6c3f1
add rest param
acocuzzo Feb 17, 2023
3318427
fix param name
acocuzzo Feb 17, 2023
19454a9
remove rest
acocuzzo Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions tests/system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,14 @@ def project():
yield default_project


@pytest.fixture()
def publisher():
yield pubsub_v1.PublisherClient()
@pytest.fixture(params=["grpc"])
def publisher(request):
yield pubsub_v1.PublisherClient(transport=request.param)


@pytest.fixture()
def subscriber():
yield pubsub_v1.SubscriberClient()
@pytest.fixture(params=["grpc"])
def subscriber(request):
yield pubsub_v1.SubscriberClient(transport=request.param)


@pytest.fixture
Expand Down Expand Up @@ -419,8 +419,8 @@ def test_subscriber_not_leaking_open_sockets(
# Also, since the client will get closed, we need another subscriber client
# to clean up the subscription. We also need to make sure that auxiliary
# subscriber releases the sockets, too.
subscriber = pubsub_v1.SubscriberClient()
subscriber_2 = pubsub_v1.SubscriberClient()
subscriber = pubsub_v1.SubscriberClient(transport="grpc")
subscriber_2 = pubsub_v1.SubscriberClient(transport="grpc")
cleanup.append(
(subscriber_2.delete_subscription, (), {"subscription": subscription_path})
)
Expand Down