-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for open telemetry #633
Conversation
chore: add a Code of Conduct (googleapis#604)
fix: lint_setup_py was failing in Kokoro is now fixed (googleapis#607)
…into opentelemetry
No region tags are edited in this PR.This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The way we're testing OT is kind of surprising, but that's largely OT's fault for being difficult to test. A few minor comments, but LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this adds the trace_call
method but does not add any calls. This means there is no tracing being added to the library. Is the intention for users to add trace calls themselves?
For the Spanner Client and the SQLAlchemy connector, we added tracing within the libraries. See here and here for more context.
So that will have to be a follow up PR, since this PR was already crossing 300 lines, I didn't add it here. Updated the description to reflect the same info. |
Add support for open telemetry tracing if open telemetry is installed.
Added the same as extra dependency.
Also added unit tests for the same.
Follow up PR to add tracing in schema with related checks in unit tests. #648
Fixes #633 🦕