-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [WIP] The first stage of nox
implementation
#468
Conversation
Below is the initial test log. Most deprecation warnings were omitted for better readability, leaving a few as an example.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick response on #466.
Before merging this nox
should run without errors. We can also lose the commented lines.
@c24t For the reference, here's the
As you might see, the assertion errors are the same as with |
SGTM as long as we've got the same failing tests in each version. Looks like 2.7 and 3.5 aren't installed on your machine? Hopefully those have the same failures. |
If the goal is to replace tox with nox, can we remove |
… by `noxfile.py`
Sure thing, both Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM to go ahead, next step is to get these (previously failing) tests working under nox
and add support for multiple django versions.
Sounds like plan, thanks! Shall it be a separate PR or an amendment to this one? |
A separate PR SGTM. One more wrinkle though, python-spanner-django/.kokoro/build.sh Lines 32 to 38 in 11222db
tox with nox .
|
👍 Good catch! Done. Just for kicks, installed Py27, Py35, and re-ran the tests - no additional errors. |
I see 43b186e removes |
Totally, as we add |
Actually, this may not even be necessary, as |
As suggested in #466 , this represents the first item of the recommended list aimed to implement
nox
testing automation in multiple steps.Change list:
noxfile.py
with the same targets as the existingtox.ini
[the commented areas reflect future targets];.gitignore
.From the results of the initial testing, the code has numerous assertion errors, see the test log below, which appear to be "normal" errors related to failing tests rather the test setup as such. Similar errors observed when using the
tox
framework.Towards #474