Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add system tests #623

Merged
merged 20 commits into from
May 20, 2021
Merged

ci: add system tests #623

merged 20 commits into from
May 20, 2021

Conversation

vi3k6i5
Copy link
Contributor

@vi3k6i5 vi3k6i5 commented May 13, 2021

ci: Adding system tests.

Currently tests are split into 3 parts:

  1. Unit tests: Run by using command nox -s unit. This test is used for library code testing and does not interact with spanner or emulator.
  2. Github workflows: These run the django test modules one by one using sh django_test_suite.sh. These tests run agains't the emulator.
  3. Kokoro: Some of the django test modules are very time consuming and thus to reduce the total runtime of tests we use kokoro to run a few select tests cases agains't actual spanner. Command used for this is run_testing_worker.py and modules tested are listed in https://github.com/googleapis/python-spanner-django/blob/master/django_test_apps.txt.

We are introducing a new test called system tests.
These tests are similar to python spanner library system tests in the sense that they would run on github workflow. These tests would actually be interacting with emulator and using the library they would perform operations like creating table, inserting data, running queries etc.

fixes #624

@vi3k6i5 vi3k6i5 requested a review from a team as a code owner May 13, 2021 07:23
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-django API. label May 13, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 13, 2021
@larkee larkee changed the title ci: Adding system tests ci: add system tests May 20, 2021
Copy link
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as the tests pass 👍

@vi3k6i5 vi3k6i5 merged commit db0ab70 into googleapis:master May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner-django API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: Add system tests similar to python spanner.
3 participants