Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support foreign keys #802

Merged
merged 10 commits into from
Nov 10, 2022
Merged

feat: support foreign keys #802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7795c8c
feat: mark foreign keys as supported
IlyaFaer Sep 27, 2022
20fb919
feat: add foreign keys template
IlyaFaer Sep 30, 2022
16211a5
feat: support foreign keys
IlyaFaer Oct 14, 2022
2e80b54
fix typo
IlyaFaer Oct 14, 2022
296a84a
Use empty line for fk template.
IlyaFaer Oct 14, 2022
2654631
fix typo
IlyaFaer Oct 14, 2022
d0b49a5
fix
IlyaFaer Oct 14, 2022
3405b7e
fix
IlyaFaer Oct 14, 2022
fb04b53
fix
IlyaFaer Oct 14, 2022
e54466c
Merge branch 'main' into foreign
IlyaFaer Nov 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions django_spanner/features.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,10 @@ class DatabaseFeatures(BaseDatabaseFeatures):
has_case_insensitive_like = False
# https://cloud.google.com/spanner/quotas#query_limits
max_query_params = 900
supports_foreign_keys = False
if os.environ.get("RUNNING_SPANNER_BACKEND_TESTS") == "1":
supports_foreign_keys = False
else:
supports_foreign_keys = True
can_create_inline_fk = False
supports_ignore_conflicts = False
supports_partial_indexes = False
Expand Down Expand Up @@ -1343,7 +1346,6 @@ class DatabaseFeatures(BaseDatabaseFeatures):
"many_to_one.tests.ManyToOneTests.test_add_after_prefetch", # noqa
"many_to_one.tests.ManyToOneTests.test_add_then_remove_after_prefetch", # noqa
"many_to_one.tests.ManyToOneTests.test_cached_foreign_key_with_to_field_not_cleared_by_save", # noqa
"many_to_one.tests.ManyToOneTests.test_multiple_foreignkeys", # noqa
"many_to_one.tests.ManyToOneTests.test_reverse_foreign_key_instance_to_field_caching", # noqa
"many_to_one.tests.ManyToOneTests.test_set_after_prefetch", # noqa
"many_to_one_null.tests.ManyToOneNullTests.test_add_efficiency", # noqa
Expand Down Expand Up @@ -1509,7 +1511,6 @@ class DatabaseFeatures(BaseDatabaseFeatures):
"ordering.tests.OrderingTests.test_stop_slicing", # noqa
"ordering.tests.OrderingTests.test_stop_start_slicing", # noqa
"queries.test_bulk_update.BulkUpdateNoteTests.test_batch_size", # noqa
"queries.test_bulk_update.BulkUpdateNoteTests.test_foreign_keys_do_not_lookup", # noqa
"queries.test_bulk_update.BulkUpdateNoteTests.test_functions", # noqa
"queries.test_bulk_update.BulkUpdateNoteTests.test_set_field_to_null", # noqa
"queries.test_bulk_update.BulkUpdateNoteTests.test_set_mixed_fields_to_null", # noqa
Expand Down
11 changes: 9 additions & 2 deletions django_spanner/schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,9 @@
# Use of this source code is governed by a BSD-style
# license that can be found in the LICENSE file or at
# https://developers.google.com/open-source/licenses/bsd

import os
import uuid

from django.db import NotSupportedError
from django.db.backends.base.schema import BaseDatabaseSchemaEditor
from django_spanner._opentelemetry_tracing import trace_call
Expand All @@ -21,7 +22,13 @@ class DatabaseSchemaEditor(BaseDatabaseSchemaEditor):
"CREATE TABLE %(table)s (%(definition)s) PRIMARY KEY(%(primary_key)s)"
)
sql_delete_table = "DROP TABLE %(table)s"
sql_create_fk = None
if os.environ.get("RUNNING_SPANNER_BACKEND_TESTS") == "1":
sql_create_fk = None
else:
sql_create_fk = (
"ALTER TABLE %(table)s ADD CONSTRAINT %(name)s FOREIGN KEY (%(column)s) "
"REFERENCES %(to_table)s (%(to_column)s)"
)
# Spanner doesn't support partial indexes. This string omits the
# %(condition)s placeholder so that partial indexes are ignored.
sql_create_index = (
Expand Down