Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: feat: SQLAlchemy 2.0 support #314

Merged
merged 91 commits into from
Apr 19, 2023
Merged

feat: feat: SQLAlchemy 2.0 support #314

merged 91 commits into from
Apr 19, 2023

Conversation

asthamohta
Copy link
Contributor

@asthamohta asthamohta commented Apr 11, 2023

The following PR adds support for the new version of SqlAlchemy 2.0 which has been supported. The PR provides minimal support of feature which were previously supported for SqlAlchemy 1.3 and 1.4 along with a few new functionalities as provided below:

  1. Support Views
  2. Support getting table info for specific schemas
  3. Get view definition
  4. Get multi columns
  5. Get multi indexes
  6. Get multi PK constraint
  7. Get multi foreign keys
  8. Modify table names in tests to not get view info for emulator
  9. Adding test suite for 2.0 support

Along with this, we will now run SqlAlchemy 2.0 as a system test for pre-submits.

@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API. label Apr 11, 2023
google/cloud/sqlalchemy_spanner/sqlalchemy_spanner.py Outdated Show resolved Hide resolved
google/cloud/sqlalchemy_spanner/sqlalchemy_spanner.py Outdated Show resolved Hide resolved
noxfile.py Show resolved Hide resolved
test/test_suite_13.py Show resolved Hide resolved
test/test_suite_20.py Outdated Show resolved Hide resolved
test/test_suite_20.py Outdated Show resolved Hide resolved
test/test_suite_20.py Outdated Show resolved Hide resolved
@asthamohta asthamohta merged commit 61d836b into main Apr 19, 2023
@asthamohta asthamohta deleted the 20_support branch April 19, 2023 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner-sqlalchemy API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants