Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: feat: SQLAlchemy 2.0 support #314

Merged
merged 91 commits into from
Apr 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
91 commits
Select commit Hold shift + click to select a range
931fa0e
feat: SQLAlchemy 2.0 support
IlyaFaer Feb 24, 2023
863c32b
sqlalchemy 2.0 support changes
IlyaFaer Feb 26, 2023
d65091a
more change for SQLAlchemy 2.0 support
IlyaFaer Feb 27, 2023
c37b83f
more change for SQLAlchemy 2.0 support
IlyaFaer Feb 28, 2023
1663745
github workflow
asthamohta Mar 15, 2023
7f2b68c
fixing reset
asthamohta Mar 15, 2023
b60dca3
fix
asthamohta Mar 15, 2023
98f617d
changes
asthamohta Mar 17, 2023
188d439
changes
asthamohta Mar 20, 2023
8e3fada
Merge branch 'main' into 20_support
asthamohta Mar 20, 2023
5aa7ee8
skipping test
asthamohta Mar 20, 2023
e7dff4a
Merge branch '20_support' of github.com:googleapis/python-spanner-sql…
asthamohta Mar 20, 2023
972ce69
changes
asthamohta Mar 20, 2023
0b00f3c
changes
asthamohta Mar 20, 2023
e7b8df1
changes
asthamohta Mar 20, 2023
94bb8a0
changes
asthamohta Mar 20, 2023
b11ba3e
changes
asthamohta Mar 20, 2023
9d08d74
changes
asthamohta Mar 20, 2023
31c0cd9
changes
asthamohta Mar 20, 2023
914e99b
changes
asthamohta Mar 20, 2023
c299075
changes
asthamohta Mar 20, 2023
8daa585
changes
asthamohta Mar 20, 2023
89b9fb0
multi indexes
asthamohta Mar 20, 2023
e634617
Merge branch 'main' into 20_support
asthamohta Mar 21, 2023
7a5293d
fix: sqlalchemy 2.0 test cases
surbhigarg92 Mar 21, 2023
47e9a05
temp removing test_has_index
surbhigarg92 Mar 21, 2023
3d71dc8
Merge branch '20_support' of github.com:googleapis/python-spanner-sql…
asthamohta Mar 21, 2023
ceccee7
changes
asthamohta Mar 21, 2023
3e80f3e
changes
asthamohta Mar 21, 2023
d4fc2ec
changes
asthamohta Mar 21, 2023
d862492
multi_index
asthamohta Mar 30, 2023
fa30c46
multi_index
asthamohta Mar 30, 2023
2ab9054
multi_index
asthamohta Mar 30, 2023
051c3a4
multi_index
asthamohta Mar 30, 2023
f7c9ea6
changes
asthamohta Mar 30, 2023
d881c2a
changes
asthamohta Mar 30, 2023
b0398df
changes
asthamohta Mar 30, 2023
aba24fe
multi_index
asthamohta Mar 30, 2023
333332f
changes
asthamohta Mar 30, 2023
92bed90
changes
asthamohta Mar 30, 2023
cc13886
Changes
asthamohta Mar 30, 2023
326bc01
Changes
asthamohta Mar 30, 2023
7ed835a
Changes
asthamohta Mar 30, 2023
8d3494d
multi fk
asthamohta Apr 3, 2023
0b7af10
changes
asthamohta Apr 3, 2023
fe37405
changes
asthamohta Apr 3, 2023
24cd502
multi_index
asthamohta Apr 3, 2023
50a1217
changes
asthamohta Apr 3, 2023
e79efa6
changes
asthamohta Apr 3, 2023
0f3384b
changes
asthamohta Apr 3, 2023
429886b
changes
asthamohta Apr 3, 2023
c017235
changes
asthamohta Apr 3, 2023
2882330
changes
asthamohta Apr 3, 2023
b668a57
changes
asthamohta Apr 3, 2023
87372ae
changes
asthamohta Apr 3, 2023
d21c0d3
fix: test_has_index
surbhigarg92 Apr 3, 2023
72a1478
changes
asthamohta Apr 3, 2023
432dcc4
Merge branch '20_support' of github.com:googleapis/python-spanner-sql…
asthamohta Apr 3, 2023
1ca2b22
changes
asthamohta Apr 3, 2023
89d8cd3
changes
asthamohta Apr 3, 2023
db3b4c4
fix: test_has_index
surbhigarg92 Apr 3, 2023
4bf96f2
fix
surbhigarg92 Apr 3, 2023
79bf539
fix
surbhigarg92 Apr 3, 2023
b3d2a06
changes
asthamohta Apr 4, 2023
fa3f7dc
Merge branch '20_support' of github.com:googleapis/python-spanner-sql…
asthamohta Apr 4, 2023
b88437c
changes
asthamohta Apr 4, 2023
b30864b
changes
asthamohta Apr 4, 2023
67a04e4
fix
surbhigarg92 Apr 4, 2023
cea4415
changes
asthamohta Apr 4, 2023
9f96445
Merge branch '20_support' of github.com:googleapis/python-spanner-sql…
asthamohta Apr 4, 2023
b866e52
changes
asthamohta Apr 4, 2023
4165a17
changes
asthamohta Apr 4, 2023
6c3f657
fix
surbhigarg92 Apr 4, 2023
9e2ef35
adding kokoro test
asthamohta Apr 4, 2023
e6d7c0f
Merge branch '20_support' of github.com:googleapis/python-spanner-sql…
asthamohta Apr 4, 2023
57bfcf3
changes
asthamohta Apr 4, 2023
c7a0cf8
view test cases
asthamohta Apr 6, 2023
a5dc59c
changes
asthamohta Apr 10, 2023
1016b68
Merge branch 'main' into 20_support
asthamohta Apr 10, 2023
2aca7eb
changes
asthamohta Apr 10, 2023
434ce0a
Merge branch '20_support' of github.com:googleapis/python-spanner-sql…
asthamohta Apr 10, 2023
d062db8
changes
asthamohta Apr 10, 2023
348b95e
test changes
asthamohta Apr 11, 2023
fcb07c2
test changes
asthamohta Apr 11, 2023
5473339
lint
asthamohta Apr 11, 2023
daf7f05
docs
asthamohta Apr 11, 2023
378c417
review comments
asthamohta Apr 13, 2023
f945223
view testing
asthamohta Apr 14, 2023
6b1d0a2
view testing
asthamohta Apr 14, 2023
d44e73f
view testing
asthamohta Apr 15, 2023
8fa83d5
review fixes
asthamohta Apr 18, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .github/workflows/test_suite.yml
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,30 @@ jobs:
GOOGLE_CLOUD_PROJECT: appdev-soda-spanner-staging
SQLALCHEMY_SILENCE_UBER_WARNING: 1

compliance_tests_20:
runs-on: ubuntu-latest

services:
emulator-0:
image: gcr.io/cloud-spanner-emulator/emulator:latest
ports:
- 9010:9010

steps:
- name: Checkout code
uses: actions/checkout@v2
- name: Setup Python
uses: actions/setup-python@v4
with:
python-version: 3.8
- name: Install nox
run: python -m pip install nox
- name: Run Compliance Tests
run: nox -s compliance_test_20
env:
SPANNER_EMULATOR_HOST: localhost:9010
GOOGLE_CLOUD_PROJECT: appdev-soda-spanner-staging

migration_tests:
runs-on: ubuntu-latest

Expand Down
15 changes: 15 additions & 0 deletions google/cloud/sqlalchemy_spanner/requirements.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

from sqlalchemy.testing import exclusions
from sqlalchemy.testing.requirements import SuiteRequirements
from sqlalchemy.testing.exclusions import against, only_on


class Requirements(SuiteRequirements): # pragma: no cover
Expand Down Expand Up @@ -45,6 +46,15 @@ def foreign_key_constraint_name_reflection(self):
def schema_reflection(self):
return exclusions.open()

@property
def array_type(self):
return only_on([lambda config: against(config, "postgresql")])

@property
def uuid_data_type(self):
"""Return databases that support the UUID datatype."""
return only_on(("postgresql >= 8.3", "mariadb >= 10.7.0"))

@property
def implicitly_named_constraints(self):
return exclusions.open()
Expand Down Expand Up @@ -99,3 +109,8 @@ def precision_numerics_enotation_large(self):
"""target backend supports Decimal() objects using E notation
to represent very large values."""
return exclusions.open()

@property
def views(self):
"""Target database must support VIEWs."""
return exclusions.open()
Loading