fix: update dialect name for ALTER operation overrides #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IlyaFaer
added
the
type: bug
product-auto-label
bot
added
the
api: spanner
IlyaFaer
commented
Aug 25, 2022
| existing_type=sa.Unicode(200), | ||
| nullable=False, | ||
| ) | ||
| """ |
Contributor
Author
There was a problem hiding this comment.
These strings are used in migration tests as a migration script.
Adding an operation, which was failing in the original issue, to make sure the case is tested.
IlyaFaer
commented
Aug 25, 2022
| with open(files[0], "w") as f: | ||
| f.write(script_code) | ||
| with open(files[0], "wb") as f: | ||
| f.write(script_code.encode()) |
Contributor
Author
There was a problem hiding this comment.
Locally I've got an error with rewriting a migration script by a program - some symbols were missing. Rewriting the file, using bytes, fixes the problem.
asthamohta
approved these changes
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #232