Skip to content

fix: test fix #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 20, 2023
Merged

fix: test fix #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a903e1b
chore: auto-release
asthamohta Oct 4, 2022
cbda3f4
Merge remote-tracking branch 'upstream/main'
asthamohta Mar 2, 2023
71bedf5
changes
asthamohta Mar 3, 2023
c2a8f0d
changes
asthamohta Mar 3, 2023
30246cd
changes
asthamohta Mar 3, 2023
1c4eef7
changes
asthamohta Mar 3, 2023
ae3f1f3
changes
asthamohta Mar 3, 2023
3ac544c
Without changes
surbhigarg92 Mar 17, 2023
b4d66f8
Update noxfile.py
asthamohta Mar 17, 2023
cfbdbfd
changes
asthamohta Mar 17, 2023
c754b44
changes
asthamohta Mar 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/test_suite.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ jobs:
env:
SPANNER_EMULATOR_HOST: localhost:9010
GOOGLE_CLOUD_PROJECT: appdev-soda-spanner-staging
SQLALCHEMY_SILENCE_UBER_WARNING: 1

migration_tests:
runs-on: ubuntu-latest
Expand Down
12 changes: 8 additions & 4 deletions noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,10 +190,9 @@ def compliance_test_14(session):

session.install("mock")
session.install("-e", ".[tracing]")
session.run("pip", "install", "sqlalchemy>=1.4,<2.0", "--force-reinstall")
session.run("python", "create_test_database.py")

session.install("sqlalchemy>=1.4")

session.run(
"py.test",
"--cov=google.cloud.sqlalchemy_spanner",
Expand Down Expand Up @@ -224,7 +223,7 @@ def unit(session):
@nox.session(python=DEFAULT_PYTHON_VERSION)
def migration_test(session):
"""Test migrations with SQLAlchemy v1.3.11+ and Alembic"""
session.run("pip", "install", "sqlalchemy>=1.3.11", "--force-reinstall")
session.run("pip", "install", "sqlalchemy>=1.3.11,<2.0", "--force-reinstall")
_migration_test(session)


Expand All @@ -242,6 +241,11 @@ def _migration_test(session):
import os
import shutil

try:
import sqlalchemy
except:
session.run("pip", "install", "sqlalchemy>=1.3.11,<2.0", "--force-reinstall")

session.install("pytest")
session.install("-e", ".")
session.install("alembic")
Expand Down Expand Up @@ -307,7 +311,7 @@ def snippets(session):
session.skip("Credentials must be set via environment variable.")

session.install("pytest")
session.install("sqlalchemy")
session.install("sqlalchemy>=1.4,<2.0")
session.install(
"git+https://github.com/googleapis/python-spanner.git#egg=google-cloud-spanner"
)
Expand Down