Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing retry during ExecuteStreamingSql call in _restart_on_unavailable #1175

Open
harshachinta opened this issue Jul 30, 2024 · 0 comments
Open

Missing retry during ExecuteStreamingSql call in _restart_on_unavailable #1175

harshachinta opened this issue Jul 30, 2024 · 0 comments
Assignees
@harshachinta
Labels
api: spanner Issues related to the googleapis/python-spanner API. priority: p3 Desirable enhancement or fix. May not be included in next release.

Comments

@harshachinta
Copy link
Contributor

The _restart_on_unavailable method restarts an iteration in case of an UNAVAILABLE error. However, the initial RPC call for ExecuteStreamingSql/ExecuteStreamingRead to get the iterator may also fail with an UNAVAILABLE error, and this retry is not handled. Consequently, errors are surfaced to the customer where the intended behavior is to retry the requests.
One example of this issue is #1150
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Jul 30, 2024
@harshachinta harshachinta added the priority: p3 Desirable enhancement or fix. May not be included in next release. label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@harshachinta harshachinta

Labels
api: spanner Issues related to the googleapis/python-spanner API. priority: p3 Desirable enhancement or fix. May not be included in next release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@olavloite @harshachinta