Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backup tests are flaky #83

Closed
larkee opened this issue May 14, 2020 · 1 comment · Fixed by #98
Closed

Backup tests are flaky #83

larkee opened this issue May 14, 2020 · 1 comment · Fixed by #98
Assignees
@yoshi-automation
Labels
api: spanner Issues related to the googleapis/python-spanner API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@larkee
Copy link
Contributor

larkee commented May 14, 2020

The Kokoro tests are often failing on backup tests for unrelated changes. There are two problems:

The first problem can be resolved by increasing the timeout for UpdateBackup.

The second problem is difficult to replicate and the exact cause is unclear given that the tests are not run in parallel and the backups are being deleted at the end of each test. The simplest solution will be to modify the test to ensure that no backups from previous tests meet the condition.
@larkee larkee added api: spanner Issues related to the googleapis/python-spanner API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels May 14, 2020
@larkee larkee mentioned this issue May 14, 2020
Merged
@tmatsuo
Copy link
Contributor

tmatsuo commented May 15, 2020

The test job can be killed anytime, so potentially we may have leaked backups (or any other resources).

@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels May 20, 2020
@larkee larkee mentioned this issue Jun 19, 2020
Merged
@larkee larkee removed the 🚨 This issue needs some love. label Jun 19, 2020
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jun 19, 2020
gcf-merge-on-green bot pushed a commit that referenced this issue Jun 22, 2020
@larkee
ci: set up kokoro system tests to run on separate instances (#98)
2b5946d 
Closes #83
@busunkim96 busunkim96 mentioned this issue Jul 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yoshi-automation yoshi-automation

Labels
api: spanner Issues related to the googleapis/python-spanner API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: set up kokoro system tests to run on separate instances larkee/python-spanner
3 participants
@tmatsuo @larkee @yoshi-automation