Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Batch Write API implementation and samples #1027

Merged
merged 20 commits into from
Dec 3, 2023
Merged

feat: Batch Write API implementation and samples #1027

merged 20 commits into from
Dec 3, 2023

Conversation

ghost
Copy link

@ghost ghost commented Oct 19, 2023 •
edited by harshachinta
Loading

This PR adds code changes and samples for Batch Write feature.
https://cloud.google.com/spanner/docs/batch-write

@ghost ghost requested review from a team as code owners October 19, 2023 10:04
@ghost ghost requested a review from ohmayr October 19, 2023 10:04
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/python-spanner API. samples Issues that are directly related to samples. labels Oct 19, 2023
@snippet-bot
Copy link

snippet-bot bot commented Oct 19, 2023 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@ghost
Copy link
Author

ghost commented Oct 19, 2023

@harshachinta - Can you please review this PR?

@ghost ghost force-pushed the feat-batch-write branch from d47b9f2 to a32dd63 Compare October 20, 2023 06:52
@ghost ghost force-pushed the feat-batch-write branch from 0f0d42f to 96e6e15 Compare November 2, 2023 11:24
@ghost
Copy link
Author

ghost commented Nov 14, 2023

@harshachinta - Can you please review this PR?

@harshachinta / @surbhigarg92 - Can you please take a look?

harshachinta
harshachinta reviewed Nov 16, 2023
View reviewed changes
Copy link
Contributor

@harshachinta harshachinta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a look the implementation changes. Will take a look at tests tomorrow.

@ghost ghost requested a review from harshachinta November 17, 2023 08:41
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 1, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 1, 2023
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 1, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 1, 2023
@harshachinta
Copy link
Contributor

@sunnsing-google
LGTM overall, except for one comment on correct mock response. Presubmits are failing and I am trying to figure out the issue.
Will approve once the presubmits get fixed.

@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 1, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 1, 2023
@ghost
Copy link
Author

ghost commented Dec 1, 2023

@sunnsing-google LGTM overall, except for one comment on correct mock response. Presubmits are failing and I am trying to figure out the issue. Will approve once the presubmits get fixed.

Thanks. PR is updated with the test change. PTAL.

@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 2, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 2, 2023
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2023
@harshachinta harshachinta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2023
@harshachinta harshachinta added do not merge Indicates a pull request not ready for merge, due to either quality or timing. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 3, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2023
@harshachinta harshachinta removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 3, 2023
@harshachinta harshachinta merged commit aa36b07 into googleapis:main Dec 3, 2023
17 of 18 checks passed
@release-please release-please bot mentioned this pull request Dec 3, 2023
Merged
@ghost ghost deleted the feat-batch-write branch December 3, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ohmayr ohmayr Awaiting requested review from ohmayr ohmayr is a code owner automatically assigned from googleapis/python-samples-reviewers

Assignees
No one assigned
Labels
api: spanner Issues related to the googleapis/python-spanner API. samples Issues that are directly related to samples. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harshachinta @yoshi-kokoro @sunny1612