Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: samples and tests for admin database APIs #1070

Closed
wants to merge 19 commits into from

Conversation

rahul2393
Copy link
Contributor

Notes

  • Adds samples and tests for auto-generated database admin APIs.
  • The sample code style is mostly consistent with our existing samples.

depends on: #1065

@rahul2393 rahul2393 requested review from a team as code owners January 9, 2024 05:41
@rahul2393 rahul2393 requested review from rsamborski and removed request for a team January 9, 2024 05:41
Copy link

snippet-bot bot commented Jan 9, 2024

Here is the summary of changes.

You are about to add 28 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link

conventional-commit-lint-gcf bot commented Jan 9, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/python-spanner API. samples Issues that are directly related to samples. labels Jan 9, 2024
@rahul2393 rahul2393 added the automerge Merge the pull request once unit tests and other checks pass. label Jan 9, 2024
Copy link
Contributor

Your PR doesn't have any required checks. Please add required checks to your auto-gen-admin-client branch and then re-add the label. Learn more about enabling these checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks.

1 similar comment
Copy link
Contributor

Your PR doesn't have any required checks. Please add required checks to your auto-gen-admin-client branch and then re-add the label. Learn more about enabling these checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks.

@rahul2393 rahul2393 changed the base branch from auto-gen-admin-client to main January 9, 2024 06:08
@rahul2393 rahul2393 force-pushed the database-admin-samples branch from b1abf7a to 2a9182e Compare January 9, 2024 06:09
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Jan 9, 2024
@rahul2393 rahul2393 changed the title docs: samples and tests for auto-generated createDatabase and createInstance APIs docs: samples and tests for auto-generated admin database APIs Jan 9, 2024
@rahul2393 rahul2393 changed the title docs: samples and tests for auto-generated admin database APIs docs: samples and tests for admin database APIs Jan 9, 2024
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 9, 2024
@rahul2393 rahul2393 closed this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner API. samples Issues that are directly related to samples. size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant