Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Custom OpenTelemetry Exporter in for Service Metrics #1273

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

lszinv
Copy link

@lszinv lszinv commented Dec 17, 2024

This change adds an implementation for an OpenTelemetry exporter to send the following service metrics that are already present in the Go and Java clients:

  • operation_latencies
  • operation_count
  • attempt_latencies
  • attempt_count
  • gfe_latency
  • gfe_missing_header_count

Files added to a metrics folder in /google/cloud/spanner_v1/metrics

  • metrics_exporter.py - The definition for the exporter
  • constants.py - Constant values such as metric and label names to be used by both the exporter and eventual implementing code.

Based on regular client Google Cloud Monitoring exporter found here

note: CLA not signed yet, as there's a settings issue. Will have it submitted soon.
note2: Linter runs with no issues, currently working on generating code coverage report to verify full coverage.

@lszinv lszinv requested review from a team as code owners December 17, 2024 03:13
Copy link

google-cla bot commented Dec 17, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/python-spanner API. labels Dec 17, 2024
@lszinv lszinv force-pushed the lsz/GSO-11/Exporter branch 3 times, most recently from 1c9e4b8 to 606f76f Compare December 18, 2024 21:52
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 19, 2024
@rahul2393 rahul2393 assigned rahul2393 and unassigned harshachinta Dec 19, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 19, 2024
@lszinv lszinv force-pushed the lsz/GSO-11/Exporter branch from 606f76f to 2e0acea Compare December 31, 2024 22:19
google/cloud/spanner_v1/metrics/constants.py Outdated Show resolved Hide resolved
google/cloud/spanner_v1/metrics/metrics_exporter.py Outdated Show resolved Hide resolved
@lszinv lszinv requested a review from rahul2393 January 3, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the googleapis/python-spanner API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants