test: update system tests for emulator #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
hengfengli
reviewed
Jun 15, 2020
tests/system/test_system.py
Outdated
| Config.CLIENT = Client() | ||
| if USE_EMULATOR: | ||
| from google.auth.credentials import AnonymousCredentials | ||
| Config.CLIENT = Client(project='emulator-test-project', credentials=AnonymousCredentials()) |
There was a problem hiding this comment.
I wonder can we read the project from an env var instead of using a hard-coded one?
hengfengli
reviewed
Jun 15, 2020
tests/system/test_system.py
Outdated
| Config.CLIENT = Client() | ||
| if USE_EMULATOR: | ||
| from google.auth.credentials import AnonymousCredentials | ||
| emulator_project = os.getenv("GCLOUD_PROJECT") or 'emulator-test-project' |
There was a problem hiding this comment.
nits: I think you can do os.getenv("GCLOUD_PROJECT", "emulator-test-project").
skuruppu
approved these changes
Jun 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows system tests to be run against the emulator without setting
GOOGLE_APPLICATION_CREDENTIALSwith no warnings.It also skips
test_transaction_read_w_abortwhich fails due to running concurrent transactions which the emulator does not support, and removes skips fortest_execute_partitioned_dmlandtest_partition_read_w_indexwhich are now supported.