Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use converted expiration parameter for signed_query_params to generate_signed_url_v2 #105

Closed
HemangChothani opened this issue Apr 13, 2020 · 2 comments · Fixed by #106
Closed

use converted expiration parameter for signed_query_params to generate_signed_url_v2 #105

HemangChothani opened this issue Apr 13, 2020 · 2 comments · Fixed by #106
Assignees
@HemangChothani
Labels
api: storage Issues related to the googleapis/python-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@HemangChothani
Copy link
Contributor

Issue created from the comment googleapis/google-cloud-python#9889 (comment)

suspected line of code.

python-storage/google/cloud/storage/_signing.py

Line 387 in 5c04eef

"Expires": str(expiration),

/cc @frankyn
@HemangChothani HemangChothani added api: storage Issues related to the googleapis/python-storage API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Apr 13, 2020
@HemangChothani HemangChothani self-assigned this Apr 13, 2020
@frankyn
Copy link
Contributor

frankyn commented Apr 13, 2020

Should be number of seconds since epoch instead of a strict conversion from int to str type: https://cloud.google.com/storage/docs/access-control/signed-urls-v2

Could you send a PR to fix this @HemangChothani?

@HemangChothani
Copy link
Contributor Author

@frankyn Yes, for sure.

@HemangChothani HemangChothani mentioned this issue Apr 14, 2020
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Apr 16, 2020
@HemangChothani
fix(storage): remove expiration strict conversion (#106)
9550dad 
Fixes #105
cojenco pushed a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
@HemangChothani @cojenco
fix(storage): remove expiration strict conversion (googleapis#106)
3bd5bac 
Fixes googleapis#105
cojenco pushed a commit to cojenco/python-storage that referenced this issue Oct 13, 2021
@HemangChothani @cojenco
fix(storage): remove expiration strict conversion (googleapis#106)
0702055 
Fixes googleapis#105
@release-please release-please bot mentioned this issue Jan 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HemangChothani HemangChothani

Labels
api: storage Issues related to the googleapis/python-storage API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
2 participants
@frankyn @HemangChothani