Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for https://storage.googleapis.com/ URLs in Blob.from_string() #1336

Closed
wants to merge 9 commits into from
Closed

feat: Add support for https://storage.googleapis.com/ URLs in Blob.from_string() #1336

wants to merge 9 commits into from

Conversation

holtskinner
Copy link
Member

@holtskinner holtskinner commented Aug 6, 2024 •
edited
Loading

Allow creating Blobs from https://storage.googleapis.com URLs.

Example:

Blob.from_string("https://storage.googleapis.com/bucket/object")

Fixes #1299

@holtskinner holtskinner requested review from a team as code owners August 6, 2024 15:53
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: storage Issues related to the googleapis/python-storage API. labels Aug 6, 2024
@holtskinner holtskinner added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 6, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 6, 2024
@holtskinner holtskinner assigned andrewsg and unassigned cojenco Aug 12, 2024
@andrewsg
Copy link
Contributor

andrewsg commented Aug 29, 2024 •
edited
Loading

@holtskinner Sorry for the delay. I'm not sure this is safe for TPC users. We might need universe domain special casing. I will check.

@holtskinner
Copy link
Member Author

holtskinner commented Aug 29, 2024 •
edited
Loading

@holtskinner Sorry for the delay. I'm not sure this is safe for TPC users. We might need universe domain special casing. I will check.

Note - TPC (Trusted Partner Cloud)? https://www.businessinsider.com/google-cloud-europe-asia-data-sovereignty-gdpr-trusted-partner-cloud-2022-9

Could you provide more context on how this is affected? @andrewsg

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Sep 19, 2024
@holtskinner holtskinner added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 19, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 19, 2024
@holtskinner holtskinner added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 19, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 19, 2024
@holtskinner
Copy link
Member Author

Closing out after offline discussion about alignment with other languages.

@holtskinner holtskinner closed this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@andrewsg andrewsg

Labels
api: storage Issues related to the googleapis/python-storage API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support storage.googleapis.com public url at Blob.from_string
4 participants
@holtskinner @andrewsg @yoshi-kokoro @cojenco