fix: close write object stream always

[chandra-siri]

fix: close write object stream always.

otherwise Task will remain for long time until GC kills it and it'll throw this "Task was destroyed but it is pending!"

[gemini-code-assist]

Summary of Changes

Hello @chandra-siri, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue in the AsyncAppendableObjectWriter where the underlying write object stream was not consistently closed under all conditions. The modification ensures that the stream is always properly closed when the close method is invoked, enhancing resource management and preventing potential leaks. A corresponding unit test has also been adjusted to accurately validate this corrected behavior.

Highlights

• Stream Closure Logic: The close method in AsyncAppendableObjectWriter now unconditionally calls await self.write_obj_stream.close(), ensuring the underlying stream is always closed, regardless of the finalize_on_close parameter.
• Unit Test Update: The unit test test_finalize_on_close was updated to reflect the new behavior, changing the assertion from assert_not_awaited() to assert_awaited_once() for the mock stream's close method.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes a bug where the write object stream was not closed when finalize_on_close=True. The change ensures the stream is closed in both finalize and flush scenarios on close(). I've added a suggestion to make the close method more robust by using a try...finally block to guarantee that stream closure and state cleanup happen even if finalize() or flush() raises an exception.