Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: replace spurious googleapis exception w/ api_core #636

Merged
merged 1 commit into from
Oct 25, 2021
Merged

tests: replace spurious googleapis exception w/ api_core #636

merged 1 commit into from
Oct 25, 2021

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 25, 2021

Closes #630.

See #626 (comment)

@tseaver tseaver requested a review from cojenco October 25, 2021 15:42
@tseaver tseaver requested review from a team as code owners October 25, 2021 15:42
@tseaver tseaver requested a review from nicain October 25, 2021 15:42
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Oct 25, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 25, 2021
@tseaver tseaver added the samples Issues that are directly related to samples. label Oct 25, 2021
cojenco
cojenco approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@cojenco cojenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@tseaver tseaver merged commit eec54f3 into main Oct 25, 2021
@tseaver tseaver deleted the 626-remove-googleapis branch October 25, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cojenco cojenco cojenco approved these changes

@nicain nicain Awaiting requested review from nicain nicain was automatically assigned from googleapis/python-samples-owners

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tseaver @cojenco