Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(release-please)!: consolidate manifest and individual releasers #398

Merged
merged 16 commits into from
Dec 29, 2021
Merged

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Nov 24, 2021

Major update to release-please which consolidates the manifest and single
releaser behavior into a single set of strategies, which can be used
on both split and mono-repos.

feat: adds support for draft pull requests.
feat: adds support for draft releases.
refactor!: if switching to manifest releaser, release_created will only be set if "." path is published.
refactor!: switch to using @actions/core getBooleanInput, accepted values for true = ["true", "True", "TRUE"], accepted values for false = ["false", "False", "FALSE"].

Major update to release-please which consolidates the manifest and single
releaser behavior into a single set of strategies, which can be used
on both split and mono-repos.

refactor!: monorepo-tags has been retired in favor of manifest behavior
refactor!: pull request title pattern not configurable currently
@kalosisz
Copy link

hey @bcoe, I believe this would allow to create draft PR, but not draft Github releases. Am I wrong?

@live627
Copy link

live627 commented Nov 30, 2021

Can you add documentation for upgrading?

@kalosisz
Copy link

@bcoe
Copy link
Contributor Author

bcoe commented Nov 30, 2021

Could you please allow this args to set? Thanks

@kalosisz sure thing.

Can you add documentation for upgrading?

I don't believe there will ultimately be any major changes that need to be made to upgrade. There is some underlying behavior that changes, such as the branch naming convention, which does make this a breaking change (but shouldn't affect most people).

@bcoe bcoe removed the do-not-merge label Dec 23, 2021
@goatwu1993
Copy link
Contributor

goatwu1993 commented Dec 27, 2021

@bcoe maybe it is a good time to bump action/core to the latest version(1.6.0)? (since this is a major release?)

Release note: https://github.com/actions/toolkit/blob/main/packages/core/RELEASES.md

1.3.0 @action/core introduced getBooleanInput. Since core.getBooleanInput accepts fewer strings, it is a BREAKING change. Good timing to remove housemadegetBooleanInput and use core.getBooleanInput (if you like to). String accepted can be found here

1.4.0 @action/core introduced getMultilineInput which returns string[], which googleapis/release-please#1157 may take advantage of.

@chingor13
Copy link
Contributor

1.3.0 @action/core introduced getBooleanInput. Since core.getBooleanInput accepts fewer strings, it is a BREAKING change. Good timing to remove housemadegetBooleanInput and use core.getBooleanInput (if you like to). String accepted can be found here

Switching the boolean helper sounds like a good change to make before releasing v3 of the action. Perhaps in a follow-up PR before the new tag?

1.4.0 @action/core introduced getMultilineInput which returns string[], which googleapis/release-please#1157 may take advantage of.

We can use this without a breaking change when surfacing new options

@bcoe bcoe merged commit 52ffbbe into main Dec 29, 2021
@bcoe bcoe deleted the v13 branch December 29, 2021 19:54
This was referenced Dec 29, 2021
goatwu1993 pushed a commit to goatwu1993/release-please-action that referenced this pull request Jul 19, 2022
…oogleapis#398)

Major update to release-please which consolidates the manifest and single
releaser behavior into a single set of strategies, which can be used
on both split and mono-repos.

feat: adds support for draft pull requests.
feat: adds support for draft releases.
refactor!: if switching to manifest releaser, release_created will only be set if "." path is published.
refactor!: switch to using @actions/core getBooleanInput, accepted values for true = ["true", "True", "TRUE"], accepted values for false = ["false", "False", "FALSE"]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants