Skip to content

Commit

Permalink
Merge branch 'main' into dev-lerna-lite
Browse files Browse the repository at this point in the history
  • Loading branch information
chingor13 authored Sep 11, 2023
2 parents 363712c + cd0bd85 commit 09b8a1b
Show file tree
Hide file tree
Showing 5 changed files with 26 additions and 19 deletions.
3 changes: 1 addition & 2 deletions .github/sync-repo-settings.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@ branchProtectionRules:
- cla/google
- docs
- lint
- test (14)
- test (16)
- test (18)
- windows
- pattern: 12.x
isAdminEnforced: false
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [14, 16]
node: [18, 20]
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v3
Expand All @@ -32,7 +32,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v3
with:
node-version: 14
node-version: 18
- run: npm install
- run: npm test
env:
Expand All @@ -43,7 +43,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v3
with:
node-version: 14
node-version: 18
- run: npm install
- run: npm run lint
docs:
Expand All @@ -52,7 +52,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v3
with:
node-version: 14
node-version: 18
- run: npm install
- run: npm run docs
- uses: JustinBeckwith/linkinator-action@v1
Expand Down
26 changes: 17 additions & 9 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ recommend using squash-merge instead](#linear-git-commit-history-use-squash-merg

## Release Please bot does not create a release PR. Why?

### Releasable Units
### Step 1: Ensure releasable units are merged

Release Please creates a release pull request after it notices the default branch
contains "releasable units" since the last release.
Expand All @@ -150,15 +150,15 @@ prefixes: "feat", "fix", and "deps".
Some languages have their specific releasable unit configuration. For example,
"docs" is a prefix for releasable units in Java and Python.

### Re-run Release Please
### Step 2: Ensure no `autorelease: pending` or `autorelease: triggered` label in an old PR

If you think Release Please missed creating a release PR after a pull request
with a releasable unit has been merged, please re-run `release-please`. If you are using
the GitHub application, add `release-please:force-run` label to the merged pull request. If
you are using the action, look for the failed invocation and retry the workflow run.
Release Please will process the pull request immediately to find releasable units.

### Existing Pull Requests with "autorelease: pending" label
Check existing pull requests labelled with `autorelease: pending` or
`autorelease: triggered` label.
Due to GitHub API failures, it's possible that the tag was not removed
correctly upon a previous release and Release Please thinks that the previous release is
still pending.
If you're certain that there's no pending release, remove the
`autorelease: pending` or `autorelease: triggered` label.

For the GitHub application users, Release Please will not create a new pull request
if there's an existing pull request labeled as `autorelease: pending`.
Expand All @@ -168,6 +168,14 @@ If you find a release pull request with the label and it is not going to be rele
(or already released), then remove the `autorelease: pending` label and re-run Release
Please.

### Step 3: Rerun Release Please

If you think Release Please missed creating a release PR after a pull request
with a releasable unit has been merged, please re-run `release-please`. If you are using
the GitHub application, add `release-please:force-run` label to the merged pull request. If
you are using the action, look for the failed invocation and retry the workflow run.
Release Please will process the pull request immediately to find releasable units.

## Strategy (Language) types supported

Release Please automates releases for the following flavors of repositories:
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"main": "./build/src/index.js",
"bin": "./build/src/bin/release-please.js",
"scripts": {
"test": "cross-env ENVIRONMENT=test LC_ALL=en c8 mocha --recursive --timeout=5000 build/test",
"test": "cross-env ENVIRONMENT=test LC_ALL=en c8 mocha --node-option no-experimental-fetch --recursive --timeout=5000 build/test",
"docs": "echo add docs tests",
"test:snap": "SNAPSHOT_UPDATE=1 LC_ALL=en npm test",
"clean": "gts clean",
Expand Down Expand Up @@ -90,7 +90,7 @@
"jsonpath": "^1.1.1",
"node-html-parser": "^6.0.0",
"parse-github-repo-url": "^1.4.1",
"semver": "^7.0.0",
"semver": "^7.5.3",
"type-fest": "^3.0.0",
"typescript": "^4.6.4",
"unist-util-visit": "^2.0.3",
Expand All @@ -100,6 +100,6 @@
"yargs": "^17.0.0"
},
"engines": {
"node": ">=14.0.0"
"node": ">=18.0.0"
}
}

0 comments on commit 09b8a1b

Please sign in to comment.