Skip to content

Commit

Permalink
feat!: require node 18+ (#2069)
Browse files Browse the repository at this point in the history
  • Loading branch information
chingor13 authored Sep 11, 2023
1 parent 3df82e3 commit 5a50247
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 8 deletions.
7 changes: 1 addition & 6 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,12 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node: [14, 16, 18]
node: [18, 20]
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node }}
- name: Override NODE options for the most recent version
if: matrix.node == '18'
run: echo "NODE_OPTIONS=--no-experimental-fetch" >> $GITHUB_ENV
- run: node --version
# The first installation step ensures that all of our production
# dependencies work on the given Node.js version, this helps us find
Expand All @@ -36,8 +33,6 @@ jobs:
- uses: actions/setup-node@v3
with:
node-version: 18
- name: Override NODE options for the most recent version
run: echo "NODE_OPTIONS=--no-experimental-fetch" >> $env:GITHUB_ENV
- run: npm install
- run: npm test
env:
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"main": "./build/src/index.js",
"bin": "./build/src/bin/release-please.js",
"scripts": {
"test": "cross-env ENVIRONMENT=test LC_ALL=en c8 mocha --recursive --timeout=5000 build/test",
"test": "cross-env ENVIRONMENT=test LC_ALL=en c8 mocha --node-option no-experimental-fetch --recursive --timeout=5000 build/test",
"docs": "echo add docs tests",
"test:snap": "SNAPSHOT_UPDATE=1 LC_ALL=en npm test",
"clean": "gts clean",
Expand Down Expand Up @@ -104,6 +104,6 @@
"yargs": "^17.0.0"
},
"engines": {
"node": ">=14.0.0"
"node": ">=18.0.0"
}
}

0 comments on commit 5a50247

Please sign in to comment.