feat(python): read version-file from manifest

googleapis · Nov 16, 2024 · 5ab0703 · 5ab0703
1 parent 3e80797
commit 5ab0703
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 12 deletions.
diff --git a/src/strategies/base.ts b/src/strategies/base.ts
@@ -113,6 +113,7 @@ export abstract class BaseStrategy implements Strategy {
   readonly componentNoSpace?: boolean;
   readonly extraFiles: ExtraFile[];
   readonly extraLabels: string[];
+  readonly versionFile?: string;
 
   readonly changelogNotes: ChangelogNotes;
 
@@ -148,6 +149,7 @@ export abstract class BaseStrategy implements Strategy {
     this.extraFiles = options.extraFiles || [];
     this.initialVersion = options.initialVersion;
     this.extraLabels = options.extraLabels || [];
+    this.versionFile = options.versionFile;
   }
 
   /**

diff --git a/src/strategies/python.ts b/src/strategies/python.ts
@@ -105,18 +105,23 @@ export class Python extends BaseStrategy {
     if (!projectName) {
       this.logger.warn('No project/component found.');
     } else {
-      [projectName, projectName.replace(/-/g, '_')]
-        .flatMap(packageName => [
-          `${packageName}/__init__.py`,
-          `src/${packageName}/__init__.py`,
-        ])
-        .forEach(packagePath =>
-          updates.push({
-            path: this.addPath(packagePath),
-            createIfMissing: false,
-            updater: new PythonFileWithVersion({version}),
-          })
-        );
+      const versionFiles = this.versionFile
+        ? [this.versionFile]
+        : [projectName, projectName.replace(/-/g, '_')]
+            .flatMap(packageName => [
+              `${packageName}/__init__.py`,
+              `src/${packageName}/__init__.py`,
+            ]);
+      if (versionFiles.length > 0) {
+        const packagePath = versionFiles[0];
+        updates.push({
+          path: this.addPath(packagePath),
+          createIfMissing: false,
+          updater: new PythonFileWithVersion({version}),
+        });
+      } else {
+        this.logger.warn('No version file found.');
+      }
     }
 
     // There should be only one version.py, but foreach in case that is incorrect