feat: Scan readme files in java-yoshi-mono-repo strategy (#1853)

* feat: Scan readme files in java-yoshi-mono-repo strategy * chore: nothing * chore: fixing tests * chore: fixing lint * chore: fixing tests
googleapis · Feb 15, 2023 · 635cc7d · 635cc7d
1 parent b57b558
commit 635cc7d
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 0 deletions.
diff --git a/src/strategies/java-yoshi-mono-repo.ts b/src/strategies/java-yoshi-mono-repo.ts
@@ -125,6 +125,11 @@ export class JavaYoshiMonoRepo extends Java {
       this.targetBranch,
       this.path
     );
+    const readmeFilesSearch = this.github.findFilesByFilenameAndRef(
+      'README.md',
+      this.targetBranch,
+      this.path
+    );
 
     const pomFiles = await pomFilesSearch;
     pomFiles.forEach(path => {
@@ -165,6 +170,19 @@ export class JavaYoshiMonoRepo extends Java {
       });
     });
 
+    const readmeFiles = await readmeFilesSearch;
+    readmeFiles.forEach(path => {
+      updates.push({
+        path: this.addPath(path),
+        createIfMissing: false,
+        updater: new JavaUpdate({
+          version,
+          versionsMap,
+          isSnapshot: options.isSnapshot,
+        }),
+      });
+    });
+
     this.extraFiles.forEach(extraFile => {
       if (typeof extraFile === 'object') {
         return;

diff --git a/test/strategies/java-yoshi-mono-repo.ts b/test/strategies/java-yoshi-mono-repo.ts
@@ -230,6 +230,9 @@ describe('JavaYoshiMonoRepo', () => {
       findFilesStub
         .withArgs('dependencies.properties', 'main', '.')
         .resolves(['dependencies.properties']);
+      findFilesStub
+        .withArgs('README.md', 'main', '.')
+        .resolves(['path1/README.md', 'path2/README.md']);
       const getFileContentsStub = sandbox.stub(
         github,
         'getFileContentsOnBranch'
@@ -255,6 +258,8 @@ describe('JavaYoshiMonoRepo', () => {
       assertHasUpdate(updates, 'path1/build.gradle', JavaUpdate);
       assertHasUpdate(updates, 'dependencies.properties', JavaUpdate);
       assertHasUpdate(updates, 'versions.txt', VersionsManifest);
+      assertHasUpdate(updates, 'path1/README.md', JavaUpdate);
+      assertHasUpdate(updates, 'path2/README.md', JavaUpdate);
     });
 
     it('finds and updates extra files', async () => {
@@ -300,6 +305,9 @@ describe('JavaYoshiMonoRepo', () => {
       findFilesStub
         .withArgs('dependencies.properties', 'main', '.')
         .resolves(['dependencies.properties']);
+      findFilesStub
+        .withArgs('README.md', 'main', '.')
+        .resolves(['path1/README.md', 'path2/README.md']);
       const getFileContentsStub = sandbox.stub(
         github,
         'getFileContentsOnBranch'
@@ -327,6 +335,8 @@ describe('JavaYoshiMonoRepo', () => {
       assertHasUpdate(updates, 'path1/build.gradle', JavaUpdate);
       assertHasUpdate(updates, 'dependencies.properties', JavaUpdate);
       assertHasUpdate(updates, 'versions.txt', VersionsManifest);
+      assertHasUpdate(updates, 'path1/README.md', JavaUpdate);
+      assertHasUpdate(updates, 'path2/README.md', JavaUpdate);
     });
 
     it('updates changelog.json', async () => {